Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define JVM_IsFinalizationEnabled() for Java 18+ #14113

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Define JVM_IsFinalizationEnabled() for Java 18+ #14113

merged 1 commit into from
Dec 8, 2021

Conversation

keithc-ca
Copy link
Contributor

Required by

  • 8276422: Add command-line option to disable finalization

This will not be needed until the openj9-staging branch promotes, but it is safe to include now.

@keithc-ca keithc-ca requested a review from pshipton December 8, 2021 17:05
@JasonFengJ9
Copy link
Member

This is related to #14049, I will take care the command line option part then.

@JasonFengJ9 JasonFengJ9 mentioned this pull request Dec 8, 2021
Merged
JasonFengJ9
JasonFengJ9 approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@JasonFengJ9 JasonFengJ9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Created #14116 based on this.

@pshipton pshipton added this to the Release 0.31 (Java 18) milestone Dec 8, 2021
@pshipton
Copy link
Member

pshipton commented Dec 8, 2021

jenkins compile win jdknext

@pshipton
Copy link
Member

pshipton commented Dec 8, 2021 

14:14:22  f:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\j9vm\javanextvmi.c(183) : error C2220: the following warning is treated as an error
14:14:22  f:\users\jenkins\workspace\build_jdknext_x86-64_windows_personal\openj9\runtime\j9vm\javanextvmi.c(183) : warning C4716: 'JVM_IsFinalizationEnabled': must return a value

@keithc-ca
Define JVM_IsFinalizationEnabled() for Java 18+
86231f8 
Required by
* 8276422: Add command-line option to disable finalization

Signed-off-by: Keith W. Campbell <[email protected]>
@keithc-ca
Copy link
Contributor Author

Added missing return statement.

@keithc-ca
Copy link
Contributor Author

Jenkins compile win jdknext

@pshipton pshipton merged commit 6ee9560 into eclipse-openj9:master Dec 8, 2021
@keithc-ca keithc-ca deleted the finalization branch December 8, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

@JasonFengJ9 JasonFengJ9 JasonFengJ9 approved these changes

Assignees
No one assigned
Labels
comp:vm jdk18
Projects
None yet
Milestone
Release 0.31 (Java 18)
Development

Successfully merging this pull request may close these issues.
3 participants
@keithc-ca @JasonFengJ9 @pshipton