Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Late updates for LSP 3.17 #630

Merged
merged 1 commit into from
May 26, 2022

Conversation

KamasamaK
Copy link
Contributor

These are the changes to the LSP 3.17 specification that were added after it was published as done.

Signed-off-by: Matthew Brown <[email protected]>
@jonahgraham
Copy link
Contributor

We can spin up a 0.14.0 release if needed in short order, please let me know with a comment on #628

@cdietrich
Copy link
Contributor

i assume a 0.13.1 would be better for p2 consumers
as maven consumers a rebuild would be needed anway

@jonahgraham
Copy link
Contributor

i assume a 0.13.1 would be better for p2 consumers as maven consumers a rebuild would be needed anway

I advise against it because there are API changes in this commit - 0.13.0 and 0.13.1 are not interchangeable due to new fields and the changed super type hierarchy. I could be convinced otherwise though if you think it is unlikely enough for anyone to hit that problem in practice, especially as we are still officially incubating.

@cdietrich
Copy link
Contributor

Yes. The question is when it would be available. I planned to do a Xtext release on Monday

@jonahgraham
Copy link
Contributor

@cdietrich I can release very quick once it is merged as I just went through the cycle of that a few days ago. Can you or @KamasamaK or someone else approve and merge?

@jonahgraham jonahgraham self-requested a review May 26, 2022 14:33
@cdietrich cdietrich added this to the v0.14.0 milestone May 26, 2022
@cdietrich cdietrich merged commit 0ca753d into eclipse-lsp4j:main May 26, 2022
@jonahgraham jonahgraham mentioned this pull request May 26, 2022
33 tasks
@KamasamaK KamasamaK deleted the lsp-3.17-late-additions branch May 26, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants