Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP4J 0.14.0 #628

Closed
33 tasks done
jonahgraham opened this issue May 19, 2022 · 5 comments
Closed
33 tasks done

LSP4J 0.14.0 #628

jonahgraham opened this issue May 19, 2022 · 5 comments
Milestone

Comments

@jonahgraham
Copy link
Contributor

jonahgraham commented May 19, 2022

This is the Release plan and TODO list for LSP4J release v0.14.0.

Steps for Release

Items at the beginning of development

  • Create an Endgame Issue to track the release. As a starting point use documentation/releasing.md.
  • Ensure all previous Endgame issues are done.
  • Create a New milestone for the release
  • Check CHANGELOG.md is up to date. The changelog should have a version entry, release date, API Breakages and other information consistent with current entries in the changelog.
  • Check README.md is up to date. In particular that the planned release and which versions of DAP and LSP are support is listed.
  • Increment version of all feature.xml, pom.xml and any other place full version is used. (Easiest way is global find and replace, e.g. s/0.13.0/0.14.0/g and review changes.) Ensure that -SNAPSHOT is restored in the gradle/versions.gradle and releng/pom.xml
  • Enable sh './releng/deploy-build.sh' in releng/build.Jenkinsfile
  • Ensure the CI build is stable - it is always better to release a "Green Dot" build

Items in the days ahead of Release day:

  • Create release on PMI
  • Schedule the release and if needed schedule a release review on the PMI. A release review is needed every 12 months, not with each release.
  • Check CHANGELOG.md is up to date. The changelog should have a version entry, release date, API Breakages and other information consistent with current entries in the changelog.
  • Check README.md is up to date. In particular that the planned release and which versions of DAP and LSP are support is listed.
  • Check all closed PRs and Issues to make sure their milestone is set. (Note: this was not until after 0.10.0 release so many old PRs and Issues have no milestone, therefore only consider items back to approx 5 Nov 2020). This search may be useful to identify such closed issues
  • Create and analyse a japicmp report and publish it as part of the build. Ensure that the API versions are incremented accurately based on the report. The reports are part of the build in japicmp-report and generated by releng/runjapicmp.sh

Items on Release day:

  • Prepare the repo for release by:
  • Push the above change
  • Run the CI build
  • Mark the build as Keep Forever and add to the description v0.14.0
  • Deploy the release by running the Release CI job with parameters:
    • LSP4J_PUBLISH_LOCATION -> updates/releases/0.14.0 ( <-- check version number)
    • PROJECT -> lsp4j-multi-build/job/main
    • LSP4J_BUILD_NUMBER -> the build that was just run above
  • Add to the deploy job description v0.14.0
  • Promote the staged repository to maven central
    • Login to Nexus
    • go to Staging Repositories, after a short delay the staged LSP4J release should appear
    • click the staged LSP4J repo
    • press the Close button located in the toolbar. This runs activities, including checking various rules
    • once the rules are done (if successful), press the Release button (you may need to press Refresh to enable the Release button)
    • check https://search.maven.org/search?q=g:org.eclipse.lsp4j to make sure the latest release has arrived - this takes a while, 15 minutes for the files to be on the server and even longer for the search indexes to update
  • Update the meta-data on PMI downloads page
  • Tag the release. Example: git tag -a v0.14.0 HEAD -m"LSP4J 0.14.0" && git push origin v0.14.0
  • Contribute to Simrel. See Simrel contribution example
  • Create a release page on github
  • Make an announcement on lsp4j-dev based on the release page on github. Example on lsp4j-dev archives
  • Update documentation/releasing.md with any changes that may have been made to the release process.
  • Create the endgame for the next release right away, especially as version numbers and restoring -SNAPSHOT need to be done right away.
@jonahgraham jonahgraham added this to the v0.14.0 milestone May 19, 2022
This was referenced May 19, 2022
@jonahgraham
Copy link
Contributor Author

Due to #630 we are going to release 0.14.0 right away. We are using 0.14.0 (as opposed to 0.13.1) because there are small but breaking API changes.

Apologies to downstream community for the churn, hopefully LSP 3.17.0 really is "final" this time.

jonahgraham added a commit that referenced this issue May 26, 2022
Incompatible changes only told us about breaking changes that would
normally require a major new version. This change will display
changes that in Semantic Versioning would require a minor change too.
jonahgraham added a commit that referenced this issue May 26, 2022
Incompatible changes only told us about breaking changes that would
normally require a major new version. This change will display
changes that in Semantic Versioning would require a minor change too.
jonahgraham added a commit that referenced this issue May 26, 2022
@nixel2007
Copy link
Contributor

@jonahgraham except notebook support :)

@jonahgraham
Copy link
Contributor Author

jonahgraham commented May 26, 2022

@cdietrich
Copy link
Contributor

thx @jonahgraham

@jonahgraham
Copy link
Contributor Author

0.14.0 is now done - https://github.com/eclipse/lsp4j/releases/tag/v0.14.0 - onto 0.15.0 tracked #631

jonahgraham added a commit that referenced this issue May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants