Remove xtend.lib dependency

[laeubi]

Currently there are some small leftovers to xtext/xtend that seem no longer needed. This currently ties lemminx unnecessarily to xtext

FYI @szarnekow

[laeubi]

@szarnekow as you are more familiar with xtext/xtend could you probably help out to resolve this?

[angelozerr]

If I remember we have this dependecy only for ToStringBuilder.

I would like to avoid bumping lsp4ij because we need to take care of binary lemminx support and our team have no time for the moment to do that.

I suggest that you copy paste the xtend ToStribgBuilder in the lemminx utils package.

[laeubi]

I suggest that you copy paste the xtend ToStribgBuilder in the lemminx utils package.

Yes that's what I think @szarnekow recommended, but maybe thats a better task for someone familiar with xtext / lemminx.

[angelozerr]

I suggest that you copy paste the xtend ToStribgBuilder in the lemminx utils package.

Yes that's what I think @szarnekow recommended, but maybe thats a better task for someone familiar with xtext / lemminx.

We will not have time to do that.

[laeubi]

I suggest that you copy paste the xtend ToStribgBuilder in the lemminx utils package.

Yes that's what I think @szarnekow recommended, but maybe thats a better task for someone familiar with xtext / lemminx.

We will not have time to do that.

Can you give some insights about "we"? How can one help with bring lemminx forward in terms of maintenance, maybe @tfroment can help out and make this project get more resources (of whatever kind required), because XML is an important part in the IDE, especially for m2e is also dependent on this.

[laeubi]

@angelozerr I now copied this from lsp4j and adjusted for java 1.8 compatibility (some vars to actual type and a missing generic).

[laeubi]

I verified this by

				<exclusion>
					<groupId>org.eclipse.xtend</groupId>
					<artifactId>org.eclipse.xtend.lib</artifactId>
				</exclusion>

then the build succeeds as well, I think we just need to keep the dependency so it show up in the uber-jar

[szarnekow]

Certainly an interesting case, since we worked hard to remove the Xbase dependency from lsp4j in the past. According to maven central, it's not part used by lsp4 0.21.1 and newer. Maybe upgrade the lsp version, instead?

[laeubi]

Maybe upgrade the lsp version, instead?

See

• Upgrade to latest lsp4j #1629

it seems Java 1.8 compatibility is still a concern.

[angelozerr]

I suggest that you copy paste the xtend ToStribgBuilder in the lemminx utils package.

Yes that's what I think @szarnekow recommended, but maybe thats a better task for someone familiar with xtext / lemminx.

We will not have time to do that.

Can you give some insights about "we"?

@fbricon @rgrunber @datho7561 and me, but badly we are very busy with other projects since lemminx is enough stable and provide features expected for vscode xml

How can one help with bring lemminx forward in terms of maintenance, maybe @tfroment can help out and make this project get more resources (of whatever kind required), because XML is an important part in the IDE, especially for m2e is also dependent on this.

Any contribution are welcome and we will try our best to review prs

[tfroment]

Hi @angelozerr, thank you @laeubi
The Eclipse IDE working group depends on the planning council to prioritize funded development efforts (outlined at https://eclipseide.org/working-group/development-funding-initiative/) and listed on this board https://gitlab.eclipse.org/eclipse-wg/ide-wg/ide-wg-dev-funded-efforts/ide-wg-dev-funded-program-planning-council-top-issues/-/boards/1208. If the planning council deems it a high priority, it can then be considered through this process. I will share it with them.

[laeubi]

Build failures seem to be the usual instabilities, so this is ready to be merged from my side.

[angelozerr]

LGTM. Thanks @laeubi !

[rgrunber]

FWIW the same was done on eclipse-jdtls/eclipse.jdt.ls#2416 .