Upgrade to latest lsp4j #1629
Open
Upgrade to latest lsp4j #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps `lsp4j.version` from 0.20.1 to 0.22.0. Updates `org.eclipse.lsp4j:org.eclipse.lsp4j` from 0.20.1 to 0.22.0 - [Release notes](https://github.com/eclipse-lsp4j/lsp4j/releases) - [Changelog](https://github.com/eclipse-lsp4j/lsp4j/blob/main/CHANGELOG.md) - [Commits](eclipse-lsp4j/lsp4j@v0.20.1...v0.22.0) Updates `org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc` from 0.20.1 to 0.22.0 - [Release notes](https://github.com/eclipse-lsp4j/lsp4j/releases) - [Changelog](https://github.com/eclipse-lsp4j/lsp4j/blob/main/CHANGELOG.md) - [Commits](eclipse-lsp4j/lsp4j@v0.20.1...v0.22.0) --- updated-dependencies: - dependency-name: org.eclipse.lsp4j:org.eclipse.lsp4j dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Previously org.eclipse.lsp4j transitively required org.eclipse.xtend.lib but this is no longer the case, this adds it back here, but as lsp4j can work without it lemminx should also consider to drop this requirement. Also the API for WorkspaceFolder has changed here, so a test needs to be adjusted here.
|
Such a change needs further coordination as it might break extensions. |
Signed-off-by: Sebastian Zarnekow <[email protected]>
|
Upgrading lsp4j is also a problem for vscode xml because it will require for user to upgrade their java version because today java8 is only required. Hopefully we have binary support but I think it will require some fix to support binary correctly because I suppose lsp4j provides now classes that we need to declare in reflect json file. |
Remove xtend.lib dependency
|
I tried to split up at laest the removal ox xtext now: this should make things easier to upgrade later on. Another problem is that lsp4j changed a constructor in a non backward compatible way, if lsp4 could add a legacy one at laest it will work to easily upgrade if decided to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.