-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/push to quay.io #30
Feature/push to quay.io #30
Conversation
@erikbosch or @wba2hi Any idea why the tests fail? "Wasn't me" (I hope) |
Only thing I see is this here: So updating the grpcio and grpcio-tools libs most probably should fix the issue if no new breaking changes were introduced. However I don't understand where this hard dependency now comes from. We updated grpcio and grpcio-tools to 1.63.0 here #27 and everything was working fine, we didn't make any updates to requirements.txt / test-requirements.txt since then |
Will take a look at it |
My analysis in short:
Some googling did not find a quick and beautiful solution to this. This should not be a problem for already released versions, only if you build and run from scratch so maybe we can live with the limitation. Created a PR at #31 to update dependencies Alternatively we could have fixed dependencies in |
Signed-off-by: Sebastian Schildt <[email protected]>
Signed-off-by: Sebastian Schildt <[email protected]>
3aca8e9
to
e616949
Compare
Thanks for analysing this. Should be fixed now |
Do for kuksa-client what eclipse-kuksa/kuksa-databroker#36 did for databroker