Subscription not providing Updates for Array Types #27
Conversation
| @@ -12,15 +12,15 @@ colorama==0.4.6 | |||
| # via cmd2 | |||
| decorator==5.1.1 | |||
| # via jsonpath-ng | |||
| grpcio==1.56.2 | |||
| grpcio==1.63.0 | |||
There was a problem hiding this comment.
Had to update the version because of the following message:
The grpc package installed is at version 1.56.2, but the generated code in kuksa/val/v1/val_pb2_grpc.py depends on grpcio>=1.63.0. Please upgrade your grpc module to grpcio>=1.63.0 or downgrade your generated code using grpcio-tools<=1.56.2. This warning will become an error in 1.65.0, scheduled for release on June 25, 2024.
which then needed a new version of protobuf to be compatible
There was a problem hiding this comment.
I think this version should also be updated in pyproject.toml and or setup.cfg This file is generated, see comment on top. Maybe @erikbosch remembers which is the "source of truth
There was a problem hiding this comment.
Oversight on my side. Thanks for the note. I updated both of them :)
There was a problem hiding this comment.
We have a description for updating dependencies at release at: https://github.com/eclipse-kuksa/kuksa-python-sdk/wiki/Release-Process#update-dependencies
cd kuksa-client
pip-compile --upgrade --resolver=backtracking setup.cfg
pip-compile --upgrade --extra=test --output-file=test-requirements.txt --resolver=backtracking setup.cfg
If you do like that you even get a few more dependencies updated.
There was a problem hiding this comment.
Done - I did a short test again and everything looked fine, however I did only check the basic functionality (subscribe, get, set with grpc) and not wss stuff or other things
| @@ -331,7 +331,7 @@ def from_message(cls, message: types_pb2.Datapoint): | |||
| timestamp = message.timestamp.ToDatetime( | |||
| tzinfo=datetime.timezone.utc, | |||
| ) | |||
| except OverflowError: | |||
| except ValueError: | |||
There was a problem hiding this comment.
I am by the way looking at how to better integrate logger errors in the CLI - because in this case this error was not visible, right
There was a problem hiding this comment.
Yes! Nothing was visible from inside the CLI. However, please note that the line you marked is just a mandatory change from the grpc dependency update. The updated version made a test fail (due to a signature change), which was fixed here.
The real bugfix is this line here:
https://github.com/eclipse-kuksa/kuksa-python-sdk/pull/27/files#diff-2bf17a95c643b27d960c21766e25624dc770b44ee696e3097c5f07d9ecd43525R41
An uncaught exception during json.dumps caused the subscription thread to terminate and no longer processed messages. I don't think that this case is covered by the logger.
Issue was caused by an exception, which happened during the stringification of the response containing an ArrayString object. ("ArrayString object is not serializable"). Fixed by using the DatabrokerEncoder, which defines on how to serialize the ArrayString object. The same encoder is also used when printing the statements using the get command.
closes: #26