-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #252 replacement of old ports with building blocks #360
Iox #252 replacement of old ports with building blocks #360
Conversation
iceoryx_posh/include/iceoryx_posh/internal/roudi/introspection/port_introspection.hpp
Show resolved
Hide resolved
iceoryx_posh/include/iceoryx_posh/internal/roudi/introspection/port_introspection.inl
Outdated
Show resolved
Hide resolved
iceoryx_posh/include/iceoryx_posh/internal/roudi/introspection/mempool_introspection.inl
Outdated
Show resolved
Hide resolved
I would not pay for throughput calculation in every publisher just because somebody could be interested. In ROS you can do it with the tools by doing something like |
+1
Can you elaborate a bit what you have in mind? |
First have to start thinking about ;-) |
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
…nd app name Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
…, use error handler instead Signed-off-by: Mathias Kraus <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work everyone! We're nearly there :-)
Two open points left:
- @marthtz Please fix the clang build
- @elBoberido Please check if copyright notices have to be adapted for the files you touched
Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
Signed-off-by: Mathias Kraus <[email protected]>
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)Notes for Reviewer
This is about removing all old ports with building blocks. Unfortunately, it turned out this is way too big for one PR. Cleaning-up the introspection with its tests is a big task for itself, it's still missing an overhaul to only store pointers to
PortData
s and not usingPortUser
as members. In addition, introspection throughput calculation has to be re-implemented using a more sophisticated approach (e.g. only calculate it when an introspection is connected).Last, roudi portmanager (previously roudi shm) tests are currently more or less disabled. I'm still working on it.Note:
Has to be built withResolved, was an error when accidentally callingone-to-many
asget/setCapacity
hasn't been implemented to multi pusher queues!subscribe()
with an argument.Open points:
PortUser
and templates: Remove PortUser from introspection and use PortData only #401Checklist for the PR Reviewer
Post-review Checklist for the PR Author
Post-review Checklist for the Eclipse Committer
References
-Partly closes #252