Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PortUser from introspection and use PortData only #401

Closed
marthtz opened this issue Nov 30, 2020 · 1 comment
Closed

Remove PortUser from introspection and use PortData only #401

marthtz opened this issue Nov 30, 2020 · 1 comment
Labels
refactoring Refactor code without adding features
Milestone

Comments

@marthtz
Copy link
Contributor

marthtz commented Nov 30, 2020

Brief feature description

Inside introspection classes just store a pointer to PublisherPortData and don't use PublisherPortUser anymore.

Detailed information

Right now the introspection classes (port, mempool, process) are storing PublisherPortUser. These could be removed and created on the fly whenever a PortUser is needed. That'll also eliminate the template usage in the introspection classes further simplifying the introspection and its tests.

@marthtz marthtz added the refactoring Refactor code without adding features label Nov 30, 2020
@mossmaurice mossmaurice added this to the Prio 2 milestone Dec 1, 2020
@elBoberido
Copy link
Member

this makes the tests actually harder, since actual ports will be used and not Mocks. I strongly advise not to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

No branches or pull requests

3 participants