Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lerna and minimum node version #29

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Update lerna and minimum node version #29

merged 1 commit into from
Dec 13, 2022
+1,835 −1,593

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Dec 5, 2022

@tortmayr tortmayr requested a review from planger December 9, 2022 14:10
planger
planger requested changes Dec 12, 2022
View reviewed changes
Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍
I just have concerns about your personal email address, which we should replace with a generic one, I think.

Jenkinsfile Outdated Show resolved Hide resolved
@tortmayr
Repo housekeeping
ee5e753 
Update lerna and minimum node version
- eclipse-glsp/glsp#676: 
Update to lerna 6 and set node 14 as minimum engine version

- eclipse-glsp/glsp#812:
 Improve yarn scripts
    - Remove linting from prepare step
    - Add dedicated :ci scrips for testing and linting
    - Add 'all' script on root level
    - Consistently sort scripts ascending

- eclipse-glsp/glsp#680: 
Update to latest `@eclipse-glsp/config` version

- eclipse-glsp/glsp#794: Update Jenkinsfile to
    - directly include deploy step instead of spawning a new dedicated job
    - enable error reporting when master builds fail
planger
planger approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@tortmayr tortmayr merged commit 371a17b into master Dec 13, 2022
@tortmayr tortmayr deleted the issue/676 branch December 13, 2022 13:47
@debovema debovema mentioned this pull request Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planger planger planger approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tortmayr @planger