GLSP-849: Remove theia-glsp-connector #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to new `GLSPModelSource` Instead of `TheiaGLSPDiagramServer´. With this migration we also remove the concept of the `TheiaGLSPConnector`. It is no longe needed since all diagram containers are child containers of the Theia main container and have direct access to all Theia services. Refactors theia specifc GLSP customiizations/extensions into feature modules similar to how we handle it for the standalone usecase. This appraoch is now possible because the diagram container is a real child container of the Theia main container which means we have access to all Theia services. This includes - Refactoring/Renaming of the `SaveableGLSPModelSource` to`GLSPSaveable`. The saveable implementation listens to the `onDirtyStateChanged` event from the diagram `EditorContextService` - Move Theia export svg functionality from connector to dedicated `theiaExportModule` - Move forwarding to Theia selection service into dedicated `theiaSelectModule` - Move the Theia source model changed handler into dediacted `theiaSourceModelWatcherModule` - Move handling of external navigation targets into dedicated `theiaNavigationModule` - Load the Theia default feature modules in the `GLSPTheiaDiagramConfiguration` - Move server message & process handling into dedicated `notificationModule` -- Remove `GlspNotificationManager` customization as its no longer needed Another advantage of moving those bindings directly into the child contain is the multi-editor support (i.e. multiple registered GLSP editors in one instance). Previously lots of the services (like TheiaSourceModelChangedHandler) would be shared between editor implementations. Now each implementation maintains its own set of services and can customize/rebind them as needed. Fixes eclipse-glsp/glsp#849 Part of eclipse-glsp/glsp#900 Part of eclipse-glsp/glsp/issues/850 Requires eclipse-glsp/glsp-client#272
planger
approved these changes
Aug 7, 2023
| theiaExportModule, | ||
| theiaNavigationModule, | ||
| theiaSourceModelWatcherModule, | ||
| notificationModule |
There was a problem hiding this comment.
I guess we should rename that module to theiaNotificationModule for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to new
GLSPModelSourceInstead ofTheiaGLSPDiagramServer´. With this migration we also remove the concept of theTheiaGLSPConnector`. It is no longe needed since all diagram containers are child containers of the Theia main container and have direct access to all Theia services.Refactors theia specifc GLSP customiizations/extensions into feature modules similar to how we handle it for the standalone usecase. This appraoch is now possible because the diagram container is a real child container of the Theia main container which means we have access to all Theia services. This includes
SaveableGLSPModelSourcetoGLSPSaveable. The saveable implementation listens to theonDirtyStateChangedevent from the diagramEditorContextServicetheiaExportModuletheiaSelectModuletheiaSourceModelWatcherModuletheiaNavigationModuleGLSPTheiaDiagramConfigurationnotificationModule-- RemoveGlspNotificationManagercustomization as its no longer neededAnother advantage of moving those bindings directly into the child contain is the multi-editor support (i.e. multiple registered GLSP editors in one instance). Previously lots of the services (like TheiaSourceModelChangedHandler) would be shared between editor implementations. Now each implementation maintains its own set of services and can customize/rebind them as needed.
Fixes eclipse-glsp/glsp#849 Part of eclipse-glsp/glsp#900 Part of eclipse-glsp/glsp/issues/850
Requires eclipse-glsp/glsp-client#272