Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GLSP-849: Remove theia-glsp-connector (#173)
* GLSP-849: Remove theia-glsp-connector Switch to new `GLSPModelSource` Instead of `TheiaGLSPDiagramServer´. With this migration we also remove the concept of the `TheiaGLSPConnector`. It is no longe needed since all diagram containers are child containers of the Theia main container and have direct access to all Theia services. Refactors theia specifc GLSP customiizations/extensions into feature modules similar to how we handle it for the standalone usecase. This appraoch is now possible because the diagram container is a real child container of the Theia main container which means we have access to all Theia services. This includes - Refactoring/Renaming of the `SaveableGLSPModelSource` to`GLSPSaveable`. The saveable implementation listens to the `onDirtyStateChanged` event from the diagram `EditorContextService` - Move Theia export svg functionality from connector to dedicated `theiaExportModule` - Move forwarding to Theia selection service into dedicated `theiaSelectModule` - Move the Theia source model changed handler into dediacted `theiaSourceModelWatcherModule` - Move handling of external navigation targets into dedicated `theiaNavigationModule` - Load the Theia default feature modules in the `GLSPTheiaDiagramConfiguration` - Move server message & process handling into dedicated `notificationModule` -- Remove `GlspNotificationManager` customization as its no longer needed Another advantage of moving those bindings directly into the child contain is the multi-editor support (i.e. multiple registered GLSP editors in one instance). Previously lots of the services (like TheiaSourceModelChangedHandler) would be shared between editor implementations. Now each implementation maintains its own set of services and can customize/rebind them as needed. Fixes eclipse-glsp/glsp#849 Part of eclipse-glsp/glsp#900 Part of eclipse-glsp/glsp/issues/850 Requires eclipse-glsp/glsp-client#272
- Loading branch information