-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo housekeeping #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planger
requested changes
Dec 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment below. Or am I missing something?
Update lerna and minimum node version - eclipse-glsp/glsp#676: Update to lerna 6 and set node 14 as minimum engine version - eclipse-glsp/glsp#812: Improve yarn scripts - Remove linting from prepare step - Add dedicated :ci scrips for testing and linting - Add 'all' script on root level - Consistently sort scripts ascending - eclipse-glsp/glsp#680: Update to latest `@eclipse-glsp/config` version - eclipse-glsp/glsp#794: Update Jenkinsfile to - directly include the npm deploy step instead of spawning a new dedicated job - enable error reporting when master builds fail
planger
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me! 👍
tortmayr
added a commit
that referenced
this pull request
Dec 13, 2022
Update lerna and minimum node version - eclipse-glsp/glsp#676: Update to lerna 6 and set node 14 as minimum engine version - eclipse-glsp/glsp#812: Improve yarn scripts - Remove linting from prepare step - Add dedicated :ci scrips for testing and linting - Add 'all' script on root level - Consistently sort scripts ascending - eclipse-glsp/glsp#680: Update to latest `@eclipse-glsp/config` version - eclipse-glsp/glsp#794: Update Jenkinsfile to - directly include the npm deploy step instead of spawning a new dedicated job - enable error reporting when master builds fail
tortmayr
added a commit
that referenced
this pull request
Dec 13, 2022
Update lerna and minimum node version - eclipse-glsp/glsp#676: Update to lerna 6 and set node 14 as minimum engine version - eclipse-glsp/glsp#812: Improve yarn scripts - Remove linting from prepare step - Add dedicated :ci scrips for testing and linting - Add 'all' script on root level - Consistently sort scripts ascending - eclipse-glsp/glsp#680: Update to latest `@eclipse-glsp/config` version - eclipse-glsp/glsp#794: Update Jenkinsfile to - directly include the npm deploy step instead of spawning a new dedicated job - enable error reporting when master builds fail
tortmayr
added a commit
that referenced
this pull request
Dec 13, 2022
Update lerna and minimum node version - eclipse-glsp/glsp#676: Update to lerna 6 and set node 14 as minimum engine version - eclipse-glsp/glsp#812: Improve yarn scripts - Remove linting from prepare step - Add dedicated :ci scrips for testing and linting - Add 'all' script on root level - Consistently sort scripts ascending - eclipse-glsp/glsp#680: Update to latest `@eclipse-glsp/config` version - eclipse-glsp/glsp#794: Update Jenkinsfile to - directly include the npm deploy step instead of spawning a new dedicated job - enable error reporting when master builds fail
tortmayr
added a commit
that referenced
this pull request
Dec 13, 2022
Update lerna and minimum node version - eclipse-glsp/glsp#676: Update to lerna 6 and set node 14 as minimum engine version - eclipse-glsp/glsp#812: Improve yarn scripts - Remove linting from prepare step - Add dedicated :ci scrips for testing and linting - Add 'all' script on root level - Consistently sort scripts ascending - eclipse-glsp/glsp#680: Update to latest `@eclipse-glsp/config` version - eclipse-glsp/glsp#794: Update Jenkinsfile to - directly include the npm deploy step instead of spawning a new dedicated job - enable error reporting when master builds fail
tortmayr
added a commit
that referenced
this pull request
Dec 13, 2022
Update lerna and minimum node version - eclipse-glsp/glsp#676: Update to lerna 6 and set node 14 as minimum engine version - eclipse-glsp/glsp#812: Improve yarn scripts - Remove linting from prepare step - Add dedicated :ci scrips for testing and linting - Add 'all' script on root level - Consistently sort scripts ascending - eclipse-glsp/glsp#680: Update to latest `@eclipse-glsp/config` version - eclipse-glsp/glsp#794: Update Jenkinsfile to - directly include the npm deploy step instead of spawning a new dedicated job - enable error reporting when master builds fail
tortmayr
added a commit
that referenced
this pull request
Dec 13, 2022
Update lerna and minimum node version - eclipse-glsp/glsp#676: Update to lerna 6 and set node 14 as minimum engine version - eclipse-glsp/glsp#812: Improve yarn scripts - Remove linting from prepare step - Add dedicated :ci scrips for testing and linting - Add 'all' script on root level - Consistently sort scripts ascending - eclipse-glsp/glsp#680: Update to latest `@eclipse-glsp/config` version - eclipse-glsp/glsp#794: Update Jenkinsfile to - directly include the npm deploy step instead of spawning a new dedicated job - enable error reporting when master builds fail
tortmayr
added a commit
that referenced
this pull request
Dec 14, 2022
Update lerna and minimum node version - eclipse-glsp/glsp#676: Update to lerna 6 and set node 14 as minimum engine version - eclipse-glsp/glsp#812: Improve yarn scripts - Remove linting from prepare step - Add dedicated :ci scrips for testing and linting - Add 'all' script on root level - Consistently sort scripts ascending - eclipse-glsp/glsp#680: Update to latest `@eclipse-glsp/config` version - eclipse-glsp/glsp#794: Update Jenkinsfile to - directly include the npm deploy step instead of spawning a new dedicated job - enable error reporting when master builds fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update lerna and minimum node version
Update node minimum version constraint to node 14 glsp#676:
Update to lerna 6 and set node 14 as minimum engine version
Improve build scripts glsp#812:
Improve yarn scripts
Consider updating lerna and removing dependency to
mocha-jenkins-reporter
glsp#680:Update to latest
@eclipse-glsp/config
versionDouble-check Jenkins configurations to ensure that we don't exhaust resource limits glsp#794: Update Jenkinsfile to