feat: policy evaluation plan #4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
feat/4424_policy_evaluation_plan
branch
9 times, most recently
from
772eba7
to
ec991c7
Compare
wolf4ood
force-pushed
the
feat/4424_policy_evaluation_plan
branch
from
ec991c7
to
83657bd
Compare
wolf4ood
force-pushed
the
feat/4424_policy_evaluation_plan
branch
from
83657bd
to
bd39bb3
Compare
ndr-brt
approved these changes
Aug 30, 2024
...icy-engine-lib/src/main/java/org/eclipse/edc/policy/engine/plan/PolicyEvaluationPlanner.java
Outdated
Show resolved
Hide resolved
...icy-engine-lib/src/main/java/org/eclipse/edc/policy/engine/plan/PolicyEvaluationPlanner.java
Outdated
Show resolved
Hide resolved
...icy-engine-lib/src/main/java/org/eclipse/edc/policy/engine/plan/PolicyEvaluationPlanner.java
Show resolved
Hide resolved
jimmarino
approved these changes
Aug 30, 2024
...mmon/lib/policy-engine-lib/src/main/java/org/eclipse/edc/policy/engine/PolicyEngineImpl.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Introduces the policy evaluation plan and planner:
Given a
Policyand a scope, thePolicyEvaluationPlannerwill recursively visit the input policy and it builds thePolicyEvaluationPlanbased on thePolicyEngineconfiguration.The
PolicyEvaluationPlancontains all the steps that the impl ofPolicyEnginewill take when evaluating aPolicywithing a scope.Why it does that
improve policies usage and debuggability
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4424
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.