Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract a PolicyPreValidator and a PolicyPostValidator interface #4446

Closed
wolf4ood opened this issue Aug 30, 2024 · 3 comments · Fixed by #4463
Closed

Extract a PolicyPreValidator and a PolicyPostValidator interface #4446

wolf4ood opened this issue Aug 30, 2024 · 3 comments · Fixed by #4463
Labels
enhancement New feature or request

Comments

@wolf4ood
Copy link
Contributor 

          proposal for a subsequent refactoring: to extract a `PolicyPreValidator` and a `PolicyPostValidator` interface, to hide that `BiFunction<Policy, PolicyContext, Boolean>` not really readable

Originally posted by @ndr-brt in #4442 (comment)
@github-actions github-actions bot added the triage all new issues awaiting classification label Aug 30, 2024
@wolf4ood wolf4ood changed the title Proposal for a subsequent refactoring: to extract a PolicyPreValidator and a PolicyPostValidator interface, to hide that BiFunction<Policy, PolicyContext, Boolean> not really readable Extract a PolicyPreValidator and a PolicyPostValidator interface Aug 30, 2024
@wolf4ood wolf4ood added enhancement New feature or request and removed triage all new issues awaiting classification labels Aug 30, 2024
@bmg13
Copy link
Contributor

bmg13 commented Sep 9, 2024

hey @wolf4ood can you assign this to me please? :)

@bmg13 bmg13 mentioned this issue Sep 9, 2024
Closed
@wolf4ood
Copy link
Contributor Author

wolf4ood commented Sep 9, 2024

Hi @bmg13

It's already on my radar since its part of the broader story #4422

@bmg13
Copy link
Contributor

bmg13 commented Sep 9, 2024

Oh okay, was unaware, created a draft pr since saw this issue around 😅 nevermind, will close it, thanks @wolf4ood !

@wolf4ood wolf4ood mentioned this issue Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@wolf4ood @bmg13