Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing transformer registrations to data-plane-selector extensions #4391

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Aug 2, 2024

What this PR changes/adds

Adding missing transformers needed for making the data-plane-selector work as a standalone.
To verify these, the scope of RemoteDataPlaneSelectorServiceTest and DataplaneSelectorControlApiEndToEndTest has been improved

Why it does that

fix bug

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4388

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the bug Something isn't working label Aug 2, 2024
@ndr-brt ndr-brt requested a review from wolf4ood August 2, 2024 12:24
@ndr-brt ndr-brt force-pushed the 4388-register-missing-transformers branch from da98ae2 to 61e68b9 Compare August 2, 2024 12:30
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.97%. Comparing base (7f20ba5) to head (61e68b9).
Report is 374 commits behind head on main.

Files Patch % Lines
...plane/selector/RemoteDataPlaneSelectorService.java 66.66% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4391      +/-   ##
==========================================
+ Coverage   71.74%   74.97%   +3.22%     
==========================================
  Files         919     1071     +152     
  Lines       18457    21481    +3024     
  Branches     1037     1174     +137     
==========================================
+ Hits        13242    16105    +2863     
- Misses       4756     4852      +96     
- Partials      459      524      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt merged commit ba42f13 into eclipse-edc:main Aug 7, 2024
25 checks passed
@ndr-brt ndr-brt deleted the 4388-register-missing-transformers branch August 7, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors calling select with a remote DPF selector
3 participants