Errors calling select with a remote DPF selector

[luluffy007]

Bug Report

Describe the Bug

When using the select method on RemoteDataPlaneSelectorService, several errors happens on both the client and the selector API.

On the selector client :

No Transformer registered that can handle class org.eclipse.edc.spi.types.domain.DataAddress -> interface jakarta.json.JsonObject
Cannot deserialize response body as JsonObject
No Transformer registered that can handle class org.eclipse.parsson.JsonObjectBuilderImpl$JsonObjectImpl -> class org.eclipse.edc.connector.dataplane.selector.spi.instance.DataPlaneInstance
No Transformer registered that can handle class org.eclipse.parsson.JsonStringImpl -> class java.lang.Object
DataPlaneInstance must have an URL

On the selector API :

No Transformer registered that can handle class org.eclipse.parsson.JsonObjectBuilderImpl$JsonObjectImpl -> class org.eclipse.edc.connector.dataplane.selector.control.api.model.SelectionRequest
No Transformer registered that can handle class org.eclipse.parsson.JsonObjectBuilderImpl$JsonObjectImpl -> class org.eclipse.edc.spi.types.domain.DataAddress
No Transformer registered that can handle class org.eclipse.parsson.JsonObjectBuilderImpl$JsonObjectImpl -> class java.lang.Object

Expected Behavior

The selector API should return the selected data plane to the remote client.

Context Information

• EDC 0.8.1
• Separated data plane, control plane and standalone DPF selector

Possible Implementation

• For the "No transformer" errors : Register the missing transformers on the data plane selector control API and the data plane selector client.
• For the "Cannot deserialize response body as JsonObject" and "DataPlaneInstance must have an URL" errors : Configure the jackson mapper and json-ld expansion on DataPlaneSelectorClientExtension and RemoteDataPlaneSelectorService.

[github-actions]

Thanks for your contribution 🔥 We will take a look asap 🚀

[ndr-brt]

could you report the build file used to build the runtime that returned the error?

[luluffy007]

The control plane build file :

plugins {
    `java-library`
    id("application")
    id("com.github.johnrengelman.shadow") version "8.1.1"
}

repositories {
    mavenCentral()
}

dependencies {
    implementation(libs.edc.boot)
    implementation(libs.edc.connector.core)
    implementation(libs.edc.configuration.filesystem)
    implementation(libs.edc.control.plane.core)
    implementation(libs.edc.control.api.configuration)
    implementation(libs.edc.control.plane.api)
    implementation(libs.edc.http)
    implementation(libs.edc.dsp)
    implementation(libs.edc.management.api)
    implementation(libs.edc.data.plane.selector.client)
    implementation(libs.edc.transfer.data.plane.signaling)
    implementation(libs.edc.data.plane.signaling.client)
    implementation(libs.edc.iam.mock)
}

application {
    mainClass.set("org.eclipse.edc.boot.system.runtime.BaseRuntime")
}

tasks.withType<com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar> {
    mergeServiceFiles()
    archiveFileName.set("connector.jar")
    setProperty("zip64", true)
}

The selector build file :

plugins {
    `java-library`
    id("application")
    id("com.github.johnrengelman.shadow") version "8.1.1"
}

repositories {
    mavenCentral()
}

dependencies {
    implementation(libs.edc.boot)
    implementation(libs.edc.connector.core)
    implementation(libs.edc.json.ld)
    implementation(libs.edc.configuration.filesystem)
    implementation(libs.edc.http)
    implementation(libs.edc.data.plane.selector.core)
    implementation(libs.edc.data.plane.selector.control.api)
    implementation(libs.edc.control.api.configuration)
    implementation(libs.edc.data.plane.signaling.client)
}

application {
    mainClass.set("org.eclipse.edc.boot.system.runtime.BaseRuntime")
}

tasks.withType<com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar> {
    mergeServiceFiles()
    archiveFileName.set("connector.jar")
    setProperty("zip64", true)
}

The data plane build file :

plugins {
    `java-library`
    id("application")
    id("com.github.johnrengelman.shadow") version "8.1.1"
}

repositories {
    mavenCentral()
}

dependencies {
    implementation(libs.edc.boot)
    implementation(libs.edc.connector.core)
    implementation(libs.edc.configuration.filesystem)
    implementation(libs.edc.control.plane.api.client)
    implementation(libs.edc.control.api.configuration)
    implementation(libs.edc.http)
    implementation(libs.edc.data.plane.selector.client)
    implementation(libs.edc.data.plane.self.registration)
    implementation(libs.edc.data.plane.core)
    implementation(libs.edc.data.plane.signaling.api)
    implementation(libs.edc.iam.mock)

    implementation(libs.edc.transfer.spi)
    implementation(libs.edc.data.plane.http)
    implementation(libs.edc.validator.data.address.http.data)
    implementation(libs.edc.validator.data.address.s3)
    implementation(libs.edc.data.plane.aws.s3)
    implementation(libs.edc.data.plane.google.storage)
    implementation(libs.edc.data.plane.util)
}

application {
    mainClass.set("org.eclipse.edc.boot.system.runtime.BaseRuntime")
}

tasks.withType<com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar> {
    mergeServiceFiles()
    archiveFileName.set("connector.jar")
    setProperty("zip64", true)
}

[ndr-brt]

looks like the transformers are not correctly registered in the selector modules. To workaround this you can define an extension and register them by yourself, on the selector side they will be:

• JsonObjectToSelectionRequestTransformer
• JsonObjectToDataAddressTransformer
• JsonValueToGenericTypeTransformer

On the data-plane side (that I assume is what you are referring with client):

• JsonObjectFromDataAddressTransformer
• JsonObjectToDataPlaneInstanceTransformer
• JsonValueToGenericTypeTransformer

EDIT: are we talking about "selection", not "registration" right? In this case the client you are referring to would be the control-plane, not the data-plane.

Could you please detail where those logs are coming from?

[luluffy007]

Yes I'm talking about the selection on the control plane. The logs are coming from the control plane (selector client) and the selector API output. So the transformers should be registered on the control-plane and the selector.

[luluffy007]

I made a end to test if it can help : main...luluffy007:Connector:bug-selector-client

[ndr-brt]

@luluffy007 I already opened a PR: #4391