Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHE-9449: Adapt Node Js debugger to node version 8 #9612

Merged
merged 3 commits into from
May 8, 2018
Merged

CHE-9449: Adapt Node Js debugger to node version 8 #9612

merged 3 commits into from
May 8, 2018

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

Adapt Node Js debugger to node version 8

What issues does this PR fix or reference?

#9449

Release Notes

Fixed nodeJs debugger

Docs PR

N/A

@vinokurig vinokurig added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels May 4, 2018
@vinokurig vinokurig requested review from vparfonov and tolusha May 4, 2018 10:28
@vinokurig
Copy link
Contributor Author

ci-test

@tolusha
Copy link
Contributor

tolusha commented May 4, 2018

sounds good.

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9612
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vinokurig
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9612
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Contributor

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9612
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@musienko-maxim
Copy link
Contributor

The features that are covered by selenium tests passed as properly

@vinokurig
Copy link
Contributor Author

ci-build

@codenvy-ci
Copy link

Build # 4529 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4529/ to view the results.

@vinokurig
Copy link
Contributor Author

ci-build

@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4530/

@vinokurig vinokurig merged commit 324808d into master May 8, 2018
@vinokurig vinokurig deleted the CHE-9449 branch May 8, 2018 11:11
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 8, 2018
@benoitf benoitf added this to the 6.5.0 milestone May 8, 2018
hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018
@vinokurig
CHE-9449: Adapt Node Js debugger to node version 8 (eclipse-che#9612)
ca3d509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha approved these changes

@vparfonov vparfonov vparfonov approved these changes

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.
7 participants
@vinokurig @tolusha @codenvy-ci @dmytro-ndp @musienko-maxim @vparfonov @benoitf