Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] The Debugger connection does not set for NodeJS projects #9449

Closed
musienko-maxim opened this issue Apr 16, 2018 · 2 comments
Closed
Assignees
Labels
e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@musienko-maxim
Copy link
Contributor

Step to reproduce:
1 .Create nodejs hello world project from wizard
2. Open app.js file and set breakpoint for 7 string
3. Launch debugger
Expected result: The debugger connection should be set
Actual result We see notification with message like Connetcting to /projects/nameofProject/app.js. But connection is never end
OS and version:
Chrome browser, che-6.4.0, 7d31a5a

@musienko-maxim musienko-maxim added kind/bug Outline of a bug - must adhere to the bug report template. e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. labels Apr 16, 2018
@musienko-maxim musienko-maxim changed the title The Debugger connection does not set for NodeJS projects [Regression] The Debugger connection does not set for NodeJS projects Apr 16, 2018
@musienko-maxim musienko-maxim assigned vinokurig and unassigned tolusha Apr 17, 2018
@vinokurig vinokurig added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Apr 17, 2018
@vparfonov
Copy link
Contributor

Problems comes from this PR eclipse-che/che-dockerfiles#173.
Here we can to ways for fix it:

  • like workaround in nearest sprint, we will fix output parsing according new nodejs version
  • make NodeJs debugger stable to changes of this type (like node version upgrade) in future, we need to rework it totally according Nodejs debugger server returns wrong value #4720 but possibly it will take a lot of time.
    @slemeur we need to you interaction here, what do you prefer?

@slemeur
Copy link
Contributor

slemeur commented Apr 19, 2018

We should take the simplest path to resole this issue and fix the output parsing.

Improvements to the debugger will be coming with the support of the debug adapter protocol #8383

@gazarenkov gazarenkov added the severity/P1 Has a major impact to usage or development of the system. label Apr 24, 2018
@vinokurig vinokurig added the status/in-progress This issue has been taken by an engineer and is under active development. label May 3, 2018
@vinokurig vinokurig added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels May 4, 2018
@vinokurig vinokurig removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants