-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dashboard ingress #18873
Merged
Merged
Update dashboard ingress #18873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatolii Bazko <[email protected]>
che-bot
added
kind/enhancement
A feature request - must adhere to the feature request template.
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
labels
Jan 25, 2021
Kudos, SonarCloud Quality Gate passed! |
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
[crw-ci-test] |
sleshchenko
approved these changes
Jan 25, 2021
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
Happy-path tests failed due known bug #18876 |
Tested locally on minikube. |
skabashnyuk
approved these changes
Jan 26, 2021
che-bot
removed
the
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
label
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatolii Bazko [email protected]
What does this PR do?
The template needs to properly support the wildcard format.
What issues does this PR fix or reference?
The dashboard doesn't load correctly. #18813
How to test this PR?
Deploy to GKE and notice the dashboard loading.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
/cc @jasonbridges