Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard ingress #18873

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Update dashboard ingress #18873

merged 1 commit into from
Jan 26, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jan 25, 2021

Signed-off-by: Anatolii Bazko [email protected]

What does this PR do?

The template needs to properly support the wildcard format.

What issues does this PR fix or reference?

The dashboard doesn't load correctly. #18813

How to test this PR?

Deploy to GKE and notice the dashboard loading.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

/cc @jasonbridges

Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha tolusha requested a review from nickboldt as a code owner January 25, 2021 07:13
@tolusha tolusha requested a review from sleshchenko January 25, 2021 07:13
@che-bot che-bot added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jan 25, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@che-bot
Copy link
Contributor

che-bot commented Jan 25, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@tolusha
Copy link
Contributor Author

tolusha commented Jan 25, 2021

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jan 25, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@tolusha
Copy link
Contributor Author

tolusha commented Jan 26, 2021

Happy-path tests failed due known bug #18876

@tolusha
Copy link
Contributor Author

tolusha commented Jan 26, 2021

Tested locally on minikube.

@tolusha tolusha requested a review from skabashnyuk January 26, 2021 08:40
@tolusha tolusha merged commit 7101807 into master Jan 26, 2021
@tolusha tolusha deleted the fixdashboardingress branch January 26, 2021 11:01
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 26, 2021
@che-bot che-bot added this to the 7.26 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants