Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard-ingress.yaml #18720

Closed
wants to merge 1 commit into from

Conversation

jasonbridges
Copy link

@jasonbridges jasonbridges commented Jan 4, 2021

Wildcard in GKE requires end in *.

What does this PR do?

The template needs to properly support the wildcard format.

What issues does this PR fix or reference?

The dashboard doesn't load correctly.

How to test this PR?

Deploy to GKE and notice the dashboard loading.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Wildcard in GKE requires end in *.
@tolusha
Copy link
Contributor

tolusha commented Jan 4, 2021

Hello @jasonbridges
Thank you for contribution.
Pls sign the ECA https://accounts.eclipse.org/legal/eca/validation/56655

Could you elaborate more about incorrectness of dashboard loading?
Do you have any screenshots or errors ?

@tolusha
Copy link
Contributor

tolusha commented Jan 25, 2021

This PR is n't possible to merge.
So closed in favor of #18873

@tolusha tolusha closed this Jan 25, 2021
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Jan 25, 2021
@che-bot
Copy link
Contributor

che-bot commented Jan 26, 2021

Can one of the admins verify this patch?

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented Jan 26, 2021

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants