Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use location instead of Eclipse workspace path for classpath #10153

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Use location instead of Eclipse workspace path for classpath #10153

merged 1 commit into from
Jun 25, 2018

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Jun 22, 2018 •
edited
Loading

What does this PR do?

Uses location URI instead of eclipse workspace path. This is basically a bugfix

What issues does this PR fix or reference?

#10052

Release Notes

n/a: this reestablishes the same behaviour as in master

Docs PR

None

@codenvy-ci
Copy link

Can one of the admins verify this patch?

1 similar comment
@codenvy-ci
Copy link

Can one of the admins verify this patch?

@benoitf benoitf added target/branch Indicates that a PR will be merged into a branch other than master. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Jun 22, 2018
@tsmaeder tsmaeder requested a review from svor June 22, 2018 12:32
svor
svor approved these changes Jun 22, 2018
View reviewed changes
Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsmaeder just a question why did you move dto maven plugin to plugins/plugin-java/che-plugin-java-ext-jdt/org-eclipse-jdt-ui/pom.xml?
As for me we need to remove org-eclipse-jdt-ui module

@tsmaeder
Copy link
Contributor Author

@svor the code generation in the shared project is a left over from very old days and simply wrong. I have removed it in other places where it made sense before and now had to do it here.
Removing jdt.ui is a next step.

@tsmaeder tsmaeder merged commit 9d19fa1 into eclipse-che:5730_java_ls_poc Jun 25, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 25, 2018
tsmaeder added a commit that referenced this pull request Jun 26, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
6683e6e 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Jul 13, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
e454ede 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Jul 27, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
2c77bc7 
Signed-off-by: Thomas Mäder <[email protected]>
tolusha pushed a commit that referenced this pull request Aug 7, 2018
@tsmaeder @tolusha
Use location instead of Eclipse workspace path for classpath (#10153)
8298f9a 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Aug 22, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
060dbbf 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Aug 29, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
2743fa8 
Signed-off-by: Thomas Mäder <[email protected]>
tolusha pushed a commit that referenced this pull request Sep 5, 2018
@tsmaeder @tolusha
Use location instead of Eclipse workspace path for classpath (#10153)
a4ba565 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Sep 13, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
8d2976f 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Sep 20, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
7bd636a 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Sep 26, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
06f9691 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Oct 1, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
a94e721 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Oct 5, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
e6dd1c7 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Oct 12, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
b65bfe3 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Oct 16, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
93856ab 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Oct 17, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
41fd82a 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Oct 17, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
a9ffd34 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Oct 17, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
10c3768 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Oct 17, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
b9def1c 
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this pull request Oct 17, 2018
@tsmaeder
Use location instead of Eclipse workspace path for classpath (#10153)
8d5e77c 
Signed-off-by: Thomas Mäder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha approved these changes

@svor svor svor approved these changes

@evidolob evidolob Awaiting requested review from evidolob

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tsmaeder @codenvy-ci @svor @tolusha @benoitf