Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium: Source Folder Paths have wrong base #10052

Closed
tsmaeder opened this issue Jun 14, 2018 · 1 comment
Closed

Selenium: Source Folder Paths have wrong base #10052

tsmaeder opened this issue Jun 14, 2018 · 1 comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master.

Comments

@tsmaeder
Copy link
Contributor

ConfigureClasspathBaseTest fails because of the value the source folder paths we show in the dialog:
expected is '/ConfigureClasspathBase_5fah/my-lib/src/main/java', but we show '/my-lib/src/main/java'. I suspect that we are using the eclipse project path instead of the locationURI.

org.openqa.selenium.TimeoutException: Expected condition failed: waiting for org.eclipse.che.selenium.pageobject.ConfigureClasspath$$Lambda$194/1036591098@1b286f4d (tried for 5 second(s) with 500 MILLISECONDS interval) Build info: version: '3.0.1', revision: '1969d75', time: '2016-10-18 09:49:13 -0700' System info: host: 'slave4.codenvycorp.com', ip: '127.0.0.1', os.name: 'Linux', os.arch: 'amd64', os.version: '3.10.0-514.16.1.el7.x86_64', java.version: '1.8.0_102' Driver info: org.eclipse.che.selenium.core.SeleniumWebDriver at org.openqa.selenium.support.ui.WebDriverWait.timeoutException(WebDriverWait.java:80) at org.openqa.selenium.support.ui.FluentWait.until(FluentWait.java:265) at org.openqa.selenium.support.ui.FluentWait.until(FluentWait.java:205) at org.eclipse.che.selenium.pageobject.ConfigureClasspath.waitExpectedTextJarsAndFolderArea(ConfigureClasspath.java:162) at org.eclipse.che.selenium.plainjava.ConfigureClasspathBaseTest.checkConfigureClasspath(ConfigureClasspathBaseTest.java:83) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at

@tsmaeder tsmaeder added kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master. team/languages labels Jun 14, 2018
@tsmaeder tsmaeder mentioned this issue Jun 14, 2018
22 tasks
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Jun 15, 2018

There are different cases to be considered:
For Project entries, the location should resolve to a single project in the eclipse workspace. While Eclipse would support mounting the same folder in two projects, I don't think this can happen in reality. If it does, there is not really a problem, because both would share the same .classpath file, and thus present the exact same classes and reexported classpath entries to the consumer.
For source folders, we know that it must be inside the project in question. Note that we might have the same folder mounted in multiple projects, for example in the case of nested maven projects. I think it's probably best in this case to use the project-relative path to specify a folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

No branches or pull requests

1 participant