Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade VS Code yaml from 0.14.0 to 0.18.0 #19493

Closed
apupier opened this issue Apr 2, 2021 · 3 comments
Closed

Upgrade VS Code yaml from 0.14.0 to 0.18.0 #19493

apupier opened this issue Apr 2, 2021 · 3 comments
Assignees
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@apupier
Copy link
Contributor

apupier commented Apr 2, 2021

Is your enhancement related to a problem? Please describe.

it contains several bugfixes and enahncements https://marketplace.visualstudio.com/items/redhat.vscode-yaml/changelog
https://github.com/eclipse-che/che-plugin-registry/blob/13ab2ea940452ef1f07b7145702d9dc081709885/che-theia-plugins.yaml#L336

nota: a lot of other extensions relies on even older versions. For instance OpenShift connector https://github.com/eclipse-che/che-plugin-registry/blob/13ab2ea940452ef1f07b7145702d9dc081709885/che-theia-plugins.yaml#L331

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@apupier apupier added the kind/enhancement A feature request - must adhere to the feature request template. label Apr 2, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 2, 2021
@olexii4 olexii4 added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Apr 2, 2021
@l0rd l0rd added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Apr 2, 2021
@l0rd l0rd changed the title Upgrade VS Code yaml extension from 0.14.0 to 0.17.0 Upgrade VS Code yaml from 0.14.0 to 0.17.0 Apr 2, 2021
@ericwill ericwill mentioned this issue Apr 8, 2021
42 tasks
@ericwill ericwill self-assigned this Apr 14, 2021
@ericwill ericwill added this to the 7.30 milestone Apr 14, 2021
@ericwill ericwill changed the title Upgrade VS Code yaml from 0.14.0 to 0.17.0 Upgrade VS Code yaml from 0.14.0 to 0.18.0 Apr 14, 2021
@ericwill
Copy link
Contributor

We need the VS Code version to be 1.52 first, as vscode-yaml depends on that: redhat-developer/vscode-yaml#471

Theia issue: eclipse-theia/theia#9193

@ericwill ericwill removed this from the 7.30 milestone May 4, 2021
@l0rd l0rd removed the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Sep 28, 2021
@apupier
Copy link
Contributor Author

apupier commented Dec 8, 2021

VS Code API 1.52 seems now available as eclipse-theia/theia#9193 is closed
latest VS COde yaml is now 1.2.2 and still declares vs code 1.52 as minimal version required https://github.com/redhat-developer/vscode-yaml/blob/ca93afaf6867731d349e2cfef954da9f9e01786d/package.json#L27

@che-bot
Copy link
Contributor

che-bot commented Jun 6, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 6, 2022
@che-bot che-bot closed this as completed Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants