-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vscode-yaml to 0.18.0 #930
Conversation
Fixes eclipse-che/che#19493 Signed-off-by: Eric Williams <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ericwill The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/joke |
@ericwill: Did you hear about the cheese who saved the world? It was Legend-dairy! In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Testing this PR on Dev Sandbox fails with: |
Marking as draft until the monaco update in theia is complete. |
@ericwill: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ericwill: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
current version of vscode-yaml available is 1.2.0 https://github.com/redhat-developer/vscode-yaml/blob/main/CHANGELOG.md#120 |
outdated |
Signed-off-by: Eric Williams [email protected]
What does this PR do?
Updates vscode-yaml to the latest version (0.18.0)
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fixes eclipse-che/che#19493
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.