Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode-yaml to 0.18.0 #930

Closed
wants to merge 1 commit into from
Closed

Update vscode-yaml to 0.18.0 #930

wants to merge 1 commit into from

Conversation

ericwill
Copy link
Contributor

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ericwill

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ericwill
Copy link
Contributor Author

/joke

@openshift-ci-robot
Copy link

@ericwill: Did you hear about the cheese who saved the world? It was Legend-dairy!

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericwill
Copy link
Contributor Author

Testing this PR on Dev Sandbox fails with:
Activating extension 'YAML' failed: The language client requires VS Code version ^1.52.0 but received version 1.50.0

@ericwill
Copy link
Contributor Author

Marking as draft until the monaco update in theia is complete.

@ericwill ericwill marked this pull request as draft April 26, 2021 19:39
@openshift-ci
Copy link

openshift-ci bot commented May 3, 2021

@ericwill: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 8, 2021

@ericwill: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v7-images 3651fb9 link /test v7-images
ci/prow/v7-plugins-test-pr-check 3651fb9 link /test v7-plugins-test-pr-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@apupier
Copy link
Contributor

apupier commented Nov 23, 2021

current version of vscode-yaml available is 1.2.0 https://github.com/redhat-developer/vscode-yaml/blob/main/CHANGELOG.md#120

@benoitf
Copy link
Contributor

benoitf commented Mar 18, 2022

outdated

@benoitf benoitf closed this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade VS Code yaml from 0.14.0 to 0.18.0
4 participants