Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML extension requires VSCode v1.52 minimum, since v0.16.0 #471

Closed
fbaligand opened this issue Apr 5, 2021 · 3 comments · Fixed by #472
Closed

YAML extension requires VSCode v1.52 minimum, since v0.16.0 #471

fbaligand opened this issue Apr 5, 2021 · 3 comments · Fixed by #472

Comments

@fbaligand
Copy link
Contributor

fbaligand commented Apr 5, 2021

Although package.json tells that vscode required version is 1.31.0, YAML extension doesn't work with vscode versions < 1.52.
This issue happens since YAML extension v0.16.0.

For example, with version v0.15.0, I can use the YAML extension successfully in vscode v1.39.
But YAML extension v0.16.0 or v0.17.0 does not work on older vscode versions than v1.52 (I tested with several versions, including v1.51.1).

So is it a build bug? Is it a new requirement with latest versions?

@fbaligand fbaligand changed the title Extension requires VSCode v1.52 minimum YAML extension requires VSCode v1.52 minimum, since v0.16.0 Apr 5, 2021
@evidolob
Copy link
Collaborator

evidolob commented Apr 6, 2021

@fbaligand It not exactly a bug. To implement #174 we need to get latest LSP version, and it seems that LSP client requires at least v1.52 VSCode version.
We need to change supported version of VSCode in package.json.

@fbaligand
Copy link
Contributor Author

Thanks for the explanation

@fbaligand
Copy link
Contributor Author

Thanks for the package.json fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants