Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devfile icon caching for offline devfile registry #15090

Closed
amisevsk opened this issue Nov 4, 2019 · 4 comments
Closed

Devfile icon caching for offline devfile registry #15090

amisevsk opened this issue Nov 4, 2019 · 4 comments
Assignees
@amisevsk
Labels
area/devfile-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.6.0

Comments

@amisevsk
Copy link
Contributor

amisevsk commented Nov 4, 2019 •
edited
Loading

Is your enhancement related to a problem? Please describe.

The offline devfile registry still refers to icons (stored in devfiles' meta.yaml) that aren't available in the offline environment. Instead, for offline builds, the devfile registry should cache icons and use the current offline-mode rewriting functionality to rewrite these URLs to point to the cached images.

E.g. the meta.yaml should be rewritten to

---
displayName: Java Maven
description: Java Stack with OpenJDK 11 and Maven 3.6.0
tags: ["Java", "OpenJDK", "Maven", "Debian"]
icon: {{ DEVFILE_REGISTRY_URL }}/images/logo-eclipseche.svg
globalMemoryLimit: 2674Mi

which would get updated to

---
displayName: Java Maven
description: Java Stack with OpenJDK 11 and Maven 3.6.0
tags: ["Java", "OpenJDK", "Maven", "Debian"]
icon: http://devfile-registry-url.com/images/logo-eclipseche.svg
globalMemoryLimit: 2674Mi

by the entrypoint script.

Related

#15089
@amisevsk amisevsk added kind/enhancement A feature request - must adhere to the feature request template. team/osio area/devfile-registry labels Nov 4, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 4, 2019
@amisevsk amisevsk mentioned this issue Nov 4, 2019
Closed
@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 4, 2019
@ibuziuk ibuziuk added this to the 7.5.0 milestone Nov 6, 2019
@amisevsk amisevsk self-assigned this Nov 6, 2019
@amisevsk amisevsk mentioned this issue Nov 7, 2019
Merged
@ibuziuk
Copy link
Member

ibuziuk commented Nov 25, 2019

@amisevsk can we close this one?

@amisevsk
Copy link
Contributor Author

@ibuziuk I ran into a couple of issues testing a different devfile registry (the CRW one, which is slightly different) so I'd like to merge 1 more PR before we close this issue.

@amisevsk
Copy link
Contributor Author

Pending PR: eclipse-che/che-devfile-registry#150

@ibuziuk ibuziuk modified the milestones: 7.5.0, 7.6.0 Nov 27, 2019
@amisevsk
Copy link
Contributor Author

amisevsk commented Dec 4, 2019 •
edited
Loading

PR is merged; icon caching should work in all cases now (7.6.0 and 7.3.3).

@amisevsk amisevsk closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amisevsk amisevsk

Labels
area/devfile-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.6.0
Development

No branches or pull requests
3 participants
@ibuziuk @amisevsk @che-bot