This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Fix caching of images when multiple images specified #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angel Misevski <[email protected]>
amisevsk
requested review from
ibuziuk,
l0rd,
nickboldt,
rhopp,
skabashnyuk and
vparfonov
as code owners
ibuziuk
approved these changes
Nov 25, 2019
Signed-off-by: Angel Misevski <[email protected]>
|
I added a commit to resolve another issue I ran into while testing: Images can be passed with query parameters, e.g. https://raw.githubusercontent.com/redhat-developer/codeready-workspaces/master/dependencies/che-devfile-registry/images/type-java.svg?sanitize=true The devfile registry currently will save images with filename |
Closed
monaka
reviewed
Nov 27, 2019
Signed-off-by: Angel Misevski <[email protected]>
amisevsk
added a commit
to amisevsk/che-devfile-registry
that referenced
this pull request
Dec 4, 2019
* Fix caching of images when multiple images specified * Remove query parameters from filename when saving devfile icon Signed-off-by: Angel Misevski <[email protected]>
amisevsk
added a commit
that referenced
this pull request
Dec 4, 2019
* Fix caching of images when multiple images specified * Remove query parameters from filename when saving devfile icon Signed-off-by: Angel Misevski <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix bug reading list of images specified in meta.yamls, where more than one unique URL would cause caching script to fail.
What issues does this PR fix or reference?
eclipse-che/che#15293