Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard should use default icon for devfiles when actual icon is inaccessible #15089

Closed
amisevsk opened this issue Nov 4, 2019 · 5 comments · Fixed by #15181
Closed

Dashboard should use default icon for devfiles when actual icon is inaccessible #15089

amisevsk opened this issue Nov 4, 2019 · 5 comments · Fixed by #15181
Assignees
@akurinnoy
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.

Comments

@amisevsk
Copy link
Contributor

amisevsk commented Nov 4, 2019 •
edited
Loading

Is your enhancement related to a problem? Please describe.

Currently, when a dashboard's icon cannot be retrieved, the dashboard shows the 'image not found" thumbnail:

Screenshot from 2019-11-04 11-31-06

Describe the solution you'd like

Che should have a fallback icon that is displayed when images cannot be found.

Additional context

Useful for airgap/offline deployments, where images may not be available.

Related to: #15090
@amisevsk amisevsk added kind/enhancement A feature request - must adhere to the feature request template. area/dashboard labels Nov 4, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 4, 2019
@amisevsk amisevsk mentioned this issue Nov 4, 2019
Closed
@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. team/ide2 and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 4, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Nov 4, 2019

@evidolob could you please take this issue as a priority for the next sprint since it is CRW related ?

@amisevsk
Copy link
Contributor Author

amisevsk commented Nov 4, 2019

Also worth noting that if #15090 is implemented, this shouldn't be a problem for CRW. I think #15090 is easier to implement so it's not essential that this one gets done.

@benoitf
Copy link
Contributor

benoitf commented Nov 4, 2019 •
edited
Loading

Why devfile registry in offline mode is providing links to online images ?

@evidolob
Copy link
Contributor

evidolob commented Nov 5, 2019

Same question.

@l0rd l0rd mentioned this issue Nov 5, 2019
Closed
23 tasks
@amisevsk
Copy link
Contributor Author

amisevsk commented Nov 6, 2019

Because I missed that those icons were actually used anywhere (they're all the exact same link). Hence #15090.

@akurinnoy akurinnoy self-assigned this Nov 12, 2019
@akurinnoy akurinnoy added the status/in-progress This issue has been taken by an engineer and is under active development. label Nov 12, 2019
@akurinnoy akurinnoy mentioned this issue Nov 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akurinnoy akurinnoy

Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[UD] Use default icon if actual icon is not accessible eclipse-che/che
6 participants
@benoitf @evidolob @ibuziuk @amisevsk @akurinnoy @che-bot