Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add Dockerfile for OpenShift Connector plugin v0.1.1 #529

Merged
merged 2 commits into from
Nov 4, 2019

Conversation

azatsarynnyy
Copy link
Member

Signed-off-by: Artem Zatsarynnyi [email protected]

What does this PR do?

Adds Dockerfile to build an image for running OpenShift Connector Che Plugin based on the VS Code extension v0.1.1. The latest version contains an important fix for Open URL command.
Also, the Dockerfile updates odo from v1.0.0-beta5 to v1.0.0 as it's required by the VS Code extension.

What issues does this PR fix or reference?

eclipse-che/che#13406
eclipse-che/che#13410

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Nov 1, 2019

✅ E2E Happy path tests succeed 🎉

Try it

See Details

name link
che-theia docker.io/maxura/che-theia:529
che-remote-plugin-node docker.io/maxura/che-remote-plugin-node:529
che-remote-plugin-runner-java8 docker.io/maxura/che-remote-plugin-runner-java8:529
che-remote-plugin-kubernetes-tooling-1.0.0 docker.io/maxura/che-remote-plugin-kubernetes-tooling-1.0.0:529

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@azatsarynnyy
Copy link
Member Author

azatsarynnyy commented Nov 1, 2019

@benoitf if you have no objections, could you approve it, please? Thanks in advance! )

@benoitf
Copy link
Contributor

benoitf commented Nov 4, 2019

hello, do we need a new docker image if it's the same content than for the previous one ?

@benoitf
Copy link
Contributor

benoitf commented Nov 4, 2019

we can't upgrade odo for all extensions ?

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems there is a ci failure

@azatsarynnyy
Copy link
Member Author

do we need a new docker image if it's the same content than for the previous one ?

@benoitf it's not the same

we can't upgrade odo for all extensions ?

we can't because of each version of extension requires a different version of the odo tool

it seems there is a ci failure

do you happen to know can I rerun ci-build-check job through a GH comment?

@azatsarynnyy
Copy link
Member Author

BTW I think we need to deprecate all the previous versions of the plugin and remove the corresponding images

Signed-off-by: Artem Zatsarynnyi <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Nov 4, 2019

❌ E2E Happy path tests failed ❗

Try it

See Details

name link
che-theia docker.io/maxura/che-theia:529
che-remote-plugin-node docker.io/maxura/che-remote-plugin-node:529
che-remote-plugin-runner-java8 docker.io/maxura/che-remote-plugin-runner-java8:529
che-remote-plugin-kubernetes-tooling-1.0.0 docker.io/maxura/che-remote-plugin-kubernetes-tooling-1.0.0:529

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@azatsarynnyy
Copy link
Member Author

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Nov 4, 2019

✅ E2E Happy path tests succeed 🎉

Try it

See Details

name link
che-theia docker.io/maxura/che-theia:529
che-remote-plugin-node docker.io/maxura/che-remote-plugin-node:529
che-remote-plugin-runner-java8 docker.io/maxura/che-remote-plugin-runner-java8:529
che-remote-plugin-kubernetes-tooling-1.0.0 docker.io/maxura/che-remote-plugin-kubernetes-tooling-1.0.0:529

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@azatsarynnyy azatsarynnyy merged commit bcf1c25 into master Nov 4, 2019
@azatsarynnyy azatsarynnyy deleted the os-plugin-0.1.1 branch November 4, 2019 16:29
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
fix(script): bunch of update on publish script
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants