-
Notifications
You must be signed in to change notification settings - Fork 111
Add Dockerfile for OpenShift Connector plugin v0.1.1 #529
Conversation
Signed-off-by: Artem Zatsarynnyi <[email protected]>
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
@benoitf if you have no objections, could you approve it, please? Thanks in advance! ) |
hello, do we need a new docker image if it's the same content than for the previous one ? |
we can't upgrade odo for all extensions ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems there is a ci failure
@benoitf it's not the same
we can't because of each version of extension requires a different version of the odo tool
do you happen to know can I rerun ci-build-check job through a GH comment? |
BTW I think we need to deprecate all the previous versions of the plugin and remove the corresponding images |
Signed-off-by: Artem Zatsarynnyi <[email protected]>
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
crw-ci-test |
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
fix(script): bunch of update on publish script
Signed-off-by: Artem Zatsarynnyi [email protected]
What does this PR do?
Adds Dockerfile to build an image for running OpenShift Connector Che Plugin based on the VS Code extension v0.1.1. The latest version contains an important fix for
Open URL
command.Also, the Dockerfile updates odo from v1.0.0-beta5 to v1.0.0 as it's required by the VS Code extension.
What issues does this PR fix or reference?
eclipse-che/che#13406
eclipse-che/che#13410
Release Notes
Docs PR