-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenShift Connector Che Plugin v0.1.1 #283
Conversation
Signed-off-by: Artem Zatsarynnyi <[email protected]>
@azatsarynnyy Could you ping me when the image is published? I'll test it out. |
If this is something we need to do in downstream CRW 2 too, @amisevsk can you submit a similar PR for https://github.com/redhat-developer/codeready-workspaces/tree/master/dependencies/che-plugin-registry ? I won't be around to review it but others should be able to (and I believe @dmytro-ndp or @rhopp can push it if you don't have push rights). |
@amisevsk sure, I'll ping you. Currently, waiting for a review of eclipse-che/che-theia#529 |
@amisevsk FYI: the image is published https://hub.docker.com/r/eclipse/che-remote-plugin-openshift-connector-0.1.1/tags |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @azatsarynnyy! Works great -- I was able to connect to the cluster without problem.
One suggestion, below.
title: OpenShift Connector | ||
description: Interacting with Red Hat OpenShift clusters and providing a streamlined developer experience using Eclipse Che | ||
icon: https://www.eclipse.org/che/images/logo-eclipseche.svg | ||
repository: https://github.com/eclipse/che-plugin-registry/tree/master/v3/plugins/redhat/vscode-openshift-connector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally the repository should point at the repository that hosts the vscode plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi [email protected]
What does this PR do?
Adds OpenShift Connector Che Plugin v0.1.1 which is based on the VS Code extension v0.1.1.
The PR should be merged after eclipse-che/che-theia#529 is merged and plugin image is published.
closes eclipse-che/che#13406
closes eclipse-che/che#13410