If internal links are not specified, the external one should be used

[AndrienkoAleksandr]

What does this PR do?

• If internal links are not specified, the external one should be used
• Fix hang loading che-theia when internal network disabled
• Don't use deprecated CHE_API env variable.

What issues does this PR fix or reference?

eclipse-che/che#18643

Howc to test this PR?

1. Install Che using operator installer
2. Execute any workspace. Check that webview(welcome page), containers panel, list plugins works.
3. Disable internal network in the custom Che operator resource(set up to false useInternalClusterSVCNames field in the server section). Check that webview(welcome page), containers panel, list plugins works. che-theia should not hangs with loader.

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

Signed-off-by: Oleksandr Andriienko [email protected]

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1161
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1161

Test product:

• tested with Eclipse Che on K8S (minikube v1.1.1)
• E2E test scenario
• E2E test pipeline source code

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

[codecov]

Codecov Report

Merging #1161 (abc40e7) into main (c299f59) will decrease coverage by 0.10%.
The diff coverage is 22.41%.

@@            Coverage Diff             @@
##             main    #1161      +/-   ##
==========================================
- Coverage   32.78%   32.67%   -0.11%     
==========================================
  Files         290      290              
  Lines        9885     9927      +42     
  Branches     1457     1528      +71     
==========================================
+ Hits         3241     3244       +3     
+ Misses       6641     6583      -58     
- Partials        3      100      +97     

Impacted Files	Coverage Δ
...rowser/src/browser/che-mini-browser-environment.ts	0.00% <0.00%> (ø)
...he-server/src/node/che-server-http-service-impl.ts	0.00% <0.00%> (ø)
...-che-server/src/node/che-server-remote-api-impl.ts	38.88% <0.00%> (ø)
...eia-workspace/src/browser/che-navigator-widget.tsx	0.00% <0.00%> (ø)
...heia-workspace/src/browser/che-workspace-module.ts	0.00% <0.00%> (ø)
generator/src/yarn.ts	95.29% <100.00%> (+0.11%)	⬆️
...ns-plugin/src/strategy/featured-plugin-strategy.ts	100.00% <100.00%> (ø)
generator/src/json-utils.ts	25.00% <0.00%> (ø)
plugins/task-plugin/src/utils.ts	0.00% <0.00%> (ø)
plugins/ssh-plugin/src/util/util.ts	0.00% <0.00%> (ø)
... and 57 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc26e5...abc40e7. Read the comment docs.

[dmytro-ndp]

[crw-ci-test --rebuild]

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1161
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1161

Test product:

• tested with Eclipse Che on K8S (minikube v1.1.1)
• E2E test scenario
• E2E test pipeline source code

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

[che-bot]

✅ E2E Happy path tests succeed 🎉

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1161
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1161

Test product:

• tested with Eclipse Che on K8S (minikube v1.1.1)
• E2E test scenario
• E2E test pipeline source code

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe