Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot expand left panel if a direct link to a workspace is using #20494

Closed
gorshkov-leonid opened this issue Sep 21, 2021 · 5 comments
Closed
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@gorshkov-leonid
Copy link

Describe the bug

Prehistory of my case:

it is related to eclipse-theia/theia#8292.
But because workspace-loader was replaced with che-dashboard this question became actual again.
I need to share a link to a specific file(with line and column) in workspace. The problem was solved with a custom plugin that reads query parameters and uses Theia API to open files. The base of the solution was the ability to pass query parameters to the plugin. It was possible with URIs like /workspace-loader/lego/temp-prj?f=/projects/22.txt&l=61&c=421&uid=42

But now there is no workspace-loader and I use link from workspace dto. This works as well as earlier, except expanding left panel.

Exactly the problem is in the link that client side got from server via /services
I expect link is https://che-namespace.k8s.managed.cloud/dashboard/#/ide/admin/temp-prj. But link is: http://che-host.namespace.svc:8080/dashboard/#/ide/admin/temp-prj

Che version

7.34

Steps to reproduce

Expected behavior

As in 7.15

Runtime

Kubernetes (vanilla)

Screenshots

No response

Installation method

chectl/latest

Environment

Linux

Eclipse Che Logs

No response

Additional context

No response

@gorshkov-leonid gorshkov-leonid added the kind/bug Outline of a bug - must adhere to the bug report template. label Sep 21, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 21, 2021
@azatsarynnyy
Copy link
Member

When clicking on show-navbar button, Che-Theia sends a message to the dashboard.
I suppose this behavior has been changed in the new dashboard.
@sleshchenko could someone from your team look at this?

@azatsarynnyy azatsarynnyy added area/dashboard severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 21, 2021
@sleshchenko
Copy link
Member

@azatsarynnyy according to the shared context, I think it's the theia bug and it uses internal CHE URL (CHE_INTERNAL_URL) but should use public (CHE_URL).
Possible related PR eclipse-che/che-theia#1161

@sleshchenko sleshchenko added area/editor/theia Issues related to the che-theia IDE of Che and removed area/dashboard labels Sep 28, 2021
@azatsarynnyy
Copy link
Member

We'll look at it for 7.39.

@azatsarynnyy
Copy link
Member

I believe there's not much sense to work on that issue for us. Considering there's no IDE IFRAME in the Dashboard anymore.

@azatsarynnyy azatsarynnyy removed this from the 7.39 milestone Oct 21, 2021
@sleshchenko
Copy link
Member

but IMHO anyway we would need a way to open dashboard from the Editor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants