Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin for support asynchronous storage #525

Merged
merged 4 commits into from
Jul 10, 2020
Merged

Add plugin for support asynchronous storage #525

merged 4 commits into from
Jul 10, 2020

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Jul 8, 2020 •
edited
Loading

vparfonov added 2 commits May 6, 2020 16:14
@vparfonov
Add async storage plugin
99a1b28 
Signed-off-by: Vitalii Parfonov <[email protected]>
@vparfonov
Add memory limits
6cd8e31 
Signed-off-by: Vitalii Parfonov <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Jul 8, 2020

@vparfonov Happy Path PR check [build 159] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link URL
console https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/159/console
artifacts http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/159/

Depending on failure reason, the artifacts or deployment may not be present.

@ibuziuk ibuziuk mentioned this pull request Jul 8, 2020
Merged
@vparfonov vparfonov marked this pull request as ready for review July 8, 2020 12:54
@che-bot
Copy link
Contributor

che-bot commented Jul 8, 2020

@vparfonov Happy Path PR check [build 161] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link URL
console https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/161/console
artifacts http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/161/

Depending on failure reason, the artifacts or deployment may not be present.

ibuziuk
ibuziuk approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vparfonov LGTM
I think this PR is not dependent on others and can be merged in the first place, right?

@ibuziuk
Copy link
Member

ibuziuk commented Jul 8, 2020

[test]

@ibuziuk
Copy link
Member

ibuziuk commented Jul 8, 2020

@ericwill could you please review. Not sure if failures of PR checks are expected cc @rhopp

@ibuziuk
Copy link
Member

ibuziuk commented Jul 9, 2020

[ci-test]

ibuziuk
ibuziuk reviewed Jul 9, 2020
View reviewed changes
v3/plugins/eclipse/che-async-pv-plugin/nightly/meta.yaml Outdated
description: Che Plug-in with service to provide abilty for backup/restore project source from async storage
icon: https://www.eclipse.org/che/images/logo-eclipseche.svg
repository: https://github.com/che-incubator/workspace-data-sync
firstPublicationDate: "2020-05-01"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vparfonov worth changing the publication date

@che-bot
Copy link
Contributor

che-bot commented Jul 9, 2020

Happy path tests passed.

@ibuziuk
Copy link
Member

ibuziuk commented Jul 9, 2020

[ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jul 9, 2020

@vparfonov Happy Path PR check [build 165] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link URL
console https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/165/console
artifacts http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/165/

Depending on failure reason, the artifacts or deployment may not be present.

@benoitf
Copy link
Contributor

benoitf commented Jul 9, 2020

in the description of the PR, it says that it depends on other issues but checkbox is not checked

image

@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Jul 9, 2020 •
edited
Loading

in the description of the PR, it says that it depends on other issues but checkbox is not checked

@vparfonov LGTM I think this PR is not dependent on others and can be merged in the first place, right?

@vparfonov Sorry, Is your pr ready or dependent on other prs?

@ibuziuk
Copy link
Member

ibuziuk commented Jul 9, 2020 •
edited
Loading

in the description of the PR, it says that it depends on other issues but checkbox is not checked

this ^ is not true, I believe @vparfonov could you please update the description

@ibuziuk
Copy link
Member

ibuziuk commented Jul 9, 2020

[ci-test]

@che-bot
Copy link
Contributor

che-bot commented Jul 9, 2020

Happy path tests passed.

@vparfonov
Fix first publication date
9116416 
Signed-off-by: Vitalii Parfonov <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Jul 10, 2020

Happy path tests passed.

@vparfonov vparfonov merged commit 1dc2ad0 into master Jul 10, 2020
@vparfonov vparfonov deleted the addAsyncPVplugin branch July 10, 2020 14:26
@l0rd l0rd added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Jul 11, 2020
@vparfonov vparfonov mentioned this pull request Jul 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuziuk ibuziuk ibuziuk approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@ericwill ericwill ericwill approved these changes

@benoitf benoitf Awaiting requested review from benoitf

@vinokurig vinokurig Awaiting requested review from vinokurig

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy

Assignees
No one assigned
Labels
new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vparfonov @che-bot @ibuziuk @benoitf @AndrienkoAleksandr @ericwill @l0rd