Initial contribution for workspace sync feature #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vparfonov
force-pushed
the
init
branch
2 times, most recently
from
ac815fa to
61e138a
Compare
Signed-off-by: Vitalii Parfonov <[email protected]>
ibuziuk
reviewed
Jun 25, 2020
ibuziuk
reviewed
Jun 25, 2020
ibuziuk
reviewed
Jun 25, 2020
ibuziuk
reviewed
Jun 25, 2020
dockerfiles/agent/Dockerfile
Outdated
Comment on lines
10
to
14
| FROM alpine:3.11 | ||
|
|
||
| ENV USER=user | ||
| ENV UID=12345 | ||
| ENV GID=23456 |
There was a problem hiding this comment.
saw it in https://stackoverflow.com/questions/49955097/how-do-i-add-a-user-when-im-using-alpine-as-a-base-image/55757473#55757473 hopefully we will not have any surprises on OpenShift ;)
ibuziuk
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
LGTM as the initial contribution, just lets' push images to https://quay.io/organization/eclipse
sleshchenko
reviewed
Jun 30, 2020
Co-authored-by: Serhii Leshchenko <[email protected]>
Signed-off-by: Vitalii Parfonov <[email protected]>
Signed-off-by: Vitalii Parfonov <[email protected]>
Signed-off-by: Vitalii Parfonov <[email protected]>
sleshchenko
approved these changes
Jul 1, 2020
| COPY scripts scripts | ||
|
|
||
| # Add user that will be able to start watcher binary but nothing more | ||
| # the result will be propagated then into scratch image |
There was a problem hiding this comment.
it's not true because you don't use a scratch image but alpine
|
|
||
| FROM alpine:3.11 | ||
|
|
||
| COPY entrypoint.sh /usr/local/bin |
There was a problem hiding this comment.
Suggested change
| COPY entrypoint.sh /usr/local/bin | |
| COPY entrypoint.sh /usr/local/bin |
| echo "Changing permissions on ${f}" && chgrp -R 0 ${f} && \ | ||
| chmod -R g+rwX ${f}; \ | ||
| done \ | ||
| && apk update \ |
There was a problem hiding this comment.
should we do apk clean after installing needed stuff?
| chmod -R g+rwX ${f}; \ | ||
| done \ | ||
| && apk update \ | ||
| && apk upgrade \ |
This was referenced Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Int this initial contribution will be provided:
dokerfiles/agent/Dockerfile: based onalpine:3.11and containsrsync,curl,opensshandsupercronicwhich will replacecronfunctionality, it becausecronnot work in OpenShift (issue)dokerfiles/agent/crontask description that will initial backup operation each 10 minutesdokerfiles/agent/scriptsbash scripts for restore and backup operationwatcher/watcher.go: Go program with responsibility to start restore.sh script on startup, parse output and send progress to the client (che-theia) via websocketdokerfiles/storage/Dockerfile: based onalpine:3.11and containsrsync,opensshSigned-off-by: Vitalii Parfonov [email protected]