Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable nativeUserMode on OpenShift with devworkspace by default #978

Merged
merged 7 commits into from
Aug 6, 2021
Merged

feat: enable nativeUserMode on OpenShift with devworkspace by default #978

merged 7 commits into from
Aug 6, 2021

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Jul 30, 2021 •
edited
Loading

Signed-off-by: Michal Vala [email protected]

What does this PR do?

When che-operator is deploying on OpenShift with DevWorkspaces, enable nativeUserMode by default.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#20203

How to test this PR?

  1. deploy with chectl server:deploy --platform=openshift --installer=operator --workspace-engine=dev-workspace --che-operator-image=quay.io/mvala/che-operator:gh20203-nativeUserModeEnable (chectl will get stuck on Keycloak, but Che will deploy fine)
  2. nativeUserMode should be enabled by default

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci
Copy link

openshift-ci bot commented Jul 30, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sparkoo sparkoo changed the title enable nativeUserMode on OpenShift with devworkspace by default feat: enable nativeUserMode on OpenShift with devworkspace by default Aug 2, 2021
@sparkoo sparkoo marked this pull request as ready for review August 2, 2021 15:34
@sparkoo sparkoo mentioned this pull request Aug 2, 2021
Merged
8 tasks
@sparkoo
Copy link
Member Author

sparkoo commented Aug 2, 2021

/retest

@sparkoo
Copy link
Member Author

sparkoo commented Aug 3, 2021

/retest

2 similar comments
@sparkoo
Copy link
Member Author

sparkoo commented Aug 3, 2021

/retest

@sparkoo
Copy link
Member Author

sparkoo commented Aug 3, 2021

/retest

tolusha
tolusha approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@tolusha tolusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls rebase on master and let's wait for a green light.

controllers/che/checluster_controller.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm label Aug 4, 2021
@openshift-ci openshift-ci bot removed the lgtm label Aug 4, 2021
@sparkoo
remove redundant if check
52a8c03 
Signed-off-by: Michal Vala <[email protected]>
@tolusha
Copy link
Contributor

tolusha commented Aug 4, 2021

ci/prow/v7-stable-to-nightly is expected to fail (eclipse-che/che#20235)

@sparkoo
Copy link
Member Author

sparkoo commented Aug 4, 2021

/retest

@tolusha
Copy link
Contributor

tolusha commented Aug 4, 2021

/test v7-devworkspace-happy-path

@sparkoo
Copy link
Member Author

sparkoo commented Aug 4, 2021

devworkspace might be failing because of che-incubator/chectl#1502

@tolusha
Copy link
Contributor

tolusha commented Aug 4, 2021

It means we need chectl PR merged first

@sparkoo
Copy link
Member Author

sparkoo commented Aug 5, 2021

It means we need chectl PR merged first

I've updated the chectl PR che-incubator/chectl#1502

@sparkoo
Copy link
Member Author

sparkoo commented Aug 5, 2021

/retest

@sparkoo
Copy link
Member Author

sparkoo commented Aug 6, 2021

/retest

1 similar comment
@sparkoo
Copy link
Member Author

sparkoo commented Aug 6, 2021

/retest

@sparkoo
Copy link
Member Author

sparkoo commented Aug 6, 2021

/test v8-che-behind-proxy

1 similar comment
@sparkoo
Copy link
Member Author

sparkoo commented Aug 6, 2021

/test v8-che-behind-proxy

@openshift-ci openshift-ci bot added the lgtm label Aug 6, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 6, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sparkoo, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sparkoo sparkoo merged commit 95471df into eclipse-che:main Aug 6, 2021
@sparkoo sparkoo deleted the gh20203-nativeUserModeEnable branch August 6, 2021 16:33
@sparkoo sparkoo mentioned this pull request Aug 6, 2021
Closed
@che-bot che-bot added this to the 7.35 milestone Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha approved these changes

@AndrienkoAleksandr AndrienkoAleksandr Awaiting requested review from AndrienkoAleksandr

@flacatus flacatus Awaiting requested review from flacatus

@mmorhun mmorhun Awaiting requested review from mmorhun

@nickboldt nickboldt Awaiting requested review from nickboldt

@metlos metlos Awaiting requested review from metlos

@mshaposhnik mshaposhnik Awaiting requested review from mshaposhnik

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

@xbaran4 xbaran4 Awaiting requested review from xbaran4

Assignees

@tolusha tolusha

Labels
lgtm
Projects
None yet
Milestone
7.35
Development

Successfully merging this pull request may close these issues.
3 participants
@sparkoo @tolusha @che-bot