feat: detect nativeUserMode will be enabled so don't wait for keycloak #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Vala <[email protected]>
sparkoo
requested review from
AndrienkoAleksandr,
flacatus,
mmorhun and
tolusha
as code owners
|
/retest |
1 similar comment
|
/retest |
|
|
tolusha
reviewed
Aug 4, 2021
Merged
11 tasks
tolusha
reviewed
Aug 5, 2021
|
Pls fix all errors |
done |
sparkoo
force-pushed
the
gh20203-nativeUserModeDefault
branch
from
47281e8 to
8abdd4c
Compare
Co-authored-by: Anatolii Bazko <[email protected]> Signed-off-by: Michal Vala <[email protected]>
sparkoo
force-pushed
the
gh20203-nativeUserModeDefault
branch
from
8abdd4c to
0c66367
Compare
|
rebased so PR checks are happy |
|
@tolusha CI seems happy. can you please rereview ? |
tolusha
approved these changes
Aug 5, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sparkoo, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Pls merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Vala [email protected]
What does this PR do?
nativeUserModewill be enabled by default on openshift with devworkspaces by eclipse-che/che-operator#978. We need to reflect this in chectl so it does not wait for keycloak deployment.Because
auth.nativeUserModeis dynamicaly changed by che-operator, we don't know the value at the moment of listing the tasks. Current implementation gets and checks the current value in Keycloak deploy task. If we're deploying innativeUserMode: true, the task is skipped (see the screenshot).Screenshot/screencast of this PR
Looks like this now:
What issues does this PR fix or reference?
eclipse-che/che#20203
How to test this PR?
./bin/run server:deploy --platform=openshift --installer=operator --workspace-engine=dev-workspace --che-operator-image=quay.io/mvala/che-operator:gh20203-nativeUserModeEnablePR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.