Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Some tests in minikube in version 1.18.1 is failing. #885

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

flacatus
Copy link
Contributor

@flacatus flacatus commented Jul 1, 2021

Signed-off-by: Flavius Lacatusu [email protected]

What does this PR do?

Fix minikube tests by increasing minikube version to latest and add latest templates to che-proxy job

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

Ref PR: #861

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@flacatus
Copy link
Contributor Author

flacatus commented Jul 1, 2021

/retest

@flacatus
Copy link
Contributor Author

flacatus commented Jul 1, 2021

/test v8-che-behind-proxy

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #885 (e04381c) into main (24ac45f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage   47.40%   47.40%           
=======================================
  Files          54       54           
  Lines        5578     5578           
=======================================
  Hits         2644     2644           
  Misses       2612     2612           
  Partials      322      322           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24ac45f...e04381c. Read the comment docs.

@flacatus
Copy link
Contributor Author

flacatus commented Jul 1, 2021

/test ?

@flacatus
Copy link
Contributor Author

flacatus commented Jul 1, 2021

/retest

@flacatus flacatus requested a review from mmorhun July 1, 2021 10:33
@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2021

@flacatus: The following commands are available to trigger jobs:

  • /test v7-ci-index
  • /test v7-devworkspace-happy-path
  • /test v7-images
  • /test v7-multi-host-nightly-deployment
  • /test v7-single-host-nightly-deployment
  • /test v7-stable-to-nightly
  • /test v8-che-behind-proxy
  • /test v8-ci-index
  • /test v8-images
  • /test v8-multi-host-nightly-deployment
  • /test v8-single-host-nightly-deployment

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flacatus, mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flacatus
Copy link
Contributor Author

flacatus commented Jul 1, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2021

@flacatus: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v8-che-behind-proxy f290a53 link /test v8-che-behind-proxy
ci/prow/v8-multi-host-nightly-deployment f290a53 link /test v8-multi-host-nightly-deployment

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@flacatus flacatus merged commit f8fd11b into main Jul 1, 2021
@flacatus flacatus deleted the fix_tests branch July 1, 2021 13:54
@che-bot che-bot added this to the 7.33 milestone Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants