-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: native user authentication #861
Conversation
Signed-off-by: Michal Vala <[email protected]>
Skipping CI for Draft Pull Request. |
Signed-off-by: Michal Vala <[email protected]>
# Conflicts: # deploy/olm-catalog/nightly/eclipse-che-preview-kubernetes/manifests/che-operator.clusterserviceversion.yaml # deploy/olm-catalog/nightly/eclipse-che-preview-openshift/manifests/che-operator.clusterserviceversion.yaml
Signed-off-by: Michal Vala <[email protected]>
Files under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general sounds good
Signed-off-by: Michal Vala <[email protected]>
Signed-off-by: Michal Vala <[email protected]>
Signed-off-by: Michal Vala <[email protected]>
Signed-off-by: Michal Vala <[email protected]>
Signed-off-by: Michal Vala <[email protected]>
/retest |
# Conflicts: # deploy/olm-catalog/nightly/eclipse-che-preview-kubernetes/manifests/che-operator.clusterserviceversion.yaml # deploy/olm-catalog/nightly/eclipse-che-preview-openshift/manifests/che-operator.clusterserviceversion.yaml
Signed-off-by: Michal Vala <[email protected]>
/retest |
1 similar comment
/retest |
/retest |
Signed-off-by: Michal Vala <[email protected]>
@tolusha any other comments? I'd like to merge it on Friday. |
// Gateway sidecar responsible for authentication when NativeUserMode is enabled. | ||
// See link:https://github.com/oauth2-proxy/oauth2-proxy[oauth2-proxy] or link:https://github.com/openshift/oauth-proxy[openshift/oauth-proxy]. | ||
// +optional | ||
GatewayAuthenticationSidecarImage string `json:"gatewayAuthenticationSidecarImage,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add the *Image
config options to checluster v2 and modify the v1<->v2 conversion, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to do that. Is v2 in che-operator already?
# Conflicts: # deploy/olm-catalog/nightly/eclipse-che-preview-kubernetes/manifests/che-operator.clusterserviceversion.yaml # deploy/olm-catalog/nightly/eclipse-che-preview-openshift/manifests/che-operator.clusterserviceversion.yaml
Signed-off-by: Michal Vala <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flacatus, mmorhun, sparkoo, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
3 similar comments
/retest |
/retest |
/retest |
@sparkoo: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
Signed-off-by: Michal Vala [email protected]
What does this PR do?
This is adding support for new authentication without Keycloak. Currently it's only for OpenShift using OpenShift OAuth. It's using oauth-proxy (https://github.com/openshift/oauth-proxy) in the gateway.
Technically, it's adding
auth.nativeUserMode
field in the CR. When enabled, che-operator does not deploy keycloak AND deploys the gateway with authentication and authorization capabilities.Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#19705
How to test this PR?
I keep latest image of this PR here
quay.io/mvala/che-operator:gh19705-newAuth
Deploy with this patch:
and deploy templates from https://github.com/sparkoo/che-operator/tree/gh19705-newAuth/deploy
with
chectl server:deploy --platform=openshift --installer=operator --workspace-engine=dev-workspace --che-operator-image=quay.io/mvala/che-operator:gh19705-newAuth --che-operator-cr-patch-yaml=/tmp/che_cr.yaml --templates=/tmp/cheop-templates
Chectl will fail waiting for a keycloak, which is not deployed in nativeUserMode. However, che-operator will deploy che successfully underneath. Get the route
oc get route -n eclipse-che
and open it in browser as usual. You should be redirected to OpenShift login page, so login as any OpenShift user. After login, you should get immediately to the dashboard and you can start any devworkspace.To logout, you need to delete site cookies, this is not done yet.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.