Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update DevWorkspace Operator dependency to v0.12.2 #1302

Merged
merged 7 commits into from
Feb 1, 2022

Conversation

amisevsk
Copy link
Contributor

@amisevsk amisevsk commented Jan 27, 2022

What does this PR do?

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

Closes eclipse-che/che#21039

How to test this PR?

  1. Deploy Che Operator with DevWorkspaces enabled
  2. Create a Devfile 2.0 workspace
  3. Stop the Devfile 2.0 workspace
  4. Delete the workspace
  5. Verify that DevWorkspace resource on cluster is removed, and that finalizer on DevWorkspaceRouting is cleared

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha
Copy link
Contributor

tolusha commented Jan 28, 2022

I've updated resources, but tests fail with a error message

# github.com/devfile/devworkspace-operator/pkg/infrastructure
/home/tolusha/gocode/src/github.com/eclipse-che/che-operator/vendor/github.com/devfile/devworkspace-operator/pkg/infrastructure/namespace.go:32:18: undefined: os.ReadFile
FAIL	github.com/eclipse-che/che-operator/controllers/devworkspace/solver [build failed]
FAIL

go version
go version go1.15.12 linux/amd64

Adapt code in Che RoutingSolver to accomodate changes in DWO that
disconnect DevWorkspaceRouting resources from the upstream Devfile API

Signed-off-by: Angel Misevski <[email protected]>
@amisevsk amisevsk changed the title chore: Update DevWorkspace Operator dependency to v0.12.1 chore: Update DevWorkspace Operator dependency to v0.12.2 Jan 28, 2022
@amisevsk
Copy link
Contributor Author

amisevsk commented Jan 28, 2022

but tests fail with a error message

Go 1.16 is required for building DWO (see https://go.dev/doc/go1.16#ioutil). 1.16.12 is currently used in the docker build.

The Go 1.16 requirement was added in devfile/devworkspace-operator#705, in order to support devfile/devworkspace-operator#700 and to allow updating some other tools used (e.g. addlicense)

@tolusha
Copy link
Contributor

tolusha commented Jan 31, 2022

/retest

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #1302 (5b81a4c) into main (f021aad) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1302   +/-   ##
=======================================
  Coverage   59.75%   59.75%           
=======================================
  Files          78       78           
  Lines        6353     6353           
=======================================
  Hits         3796     3796           
  Misses       2180     2180           
  Partials      377      377           
Impacted Files Coverage Δ
controllers/devworkspace/solver/che_routing.go 77.49% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f021aad...5b81a4c. Read the comment docs.

@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DevWorkspaces resources are not removed when DevWorkspace is removed
2 participants