-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make project-clone work in a temporary directory; copy files at end #700
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, JPinkney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test v8-devworkspace-operator-e2e |
Validation is failing as |
Blocked by #705 |
a705d0b
to
45ccd5a
Compare
New changes are detected. LGTM label has been removed. |
To avoid issues where the project-clone container is killed while cloning (and thus leaving repos in an inconsistent state), do all actions to a temporary directory and move files into their expected location only as a last step. This should allow projects to be cloned correctly if the project-clone container is killed early in execution. Signed-off-by: Angel Misevski <[email protected]>
45ccd5a
to
f2de405
Compare
/test v8-devworkspace-operator-e2e |
What does this PR do?
In order to avoid issues where the project-clone container is killed during its initial run, leaving repos in a half-configured state, do all operations in a temporary directory and copy repos to their expected locations at the very end.
What issues does this PR fix or reference?
Closes #699
Is it tested? How?
Can be tested using the image
quay.io/amisevsk/project-clone:atomic-clone
(e.g. in the relevantRELATED_IMAGE
env var or by settingPROJECT_CLONE_IMG
when installing DWO). To test both git and zip type projects, use the devfileand check that
$PROJECTS_ROOT
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che