Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update from ubi8/go-toolset:1.19.13-2 to ubi8/go-toolset:1.20.10-3 #273

Closed
wants to merge 6 commits into from
Closed

chore: Update from ubi8/go-toolset:1.19.13-2 to ubi8/go-toolset:1.20.10-3 #273

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
45ea08d
chore: Update from ubi8/go-toolset:1.19.13-2 to ubi8/go-toolset:1.20.…
nickboldt Nov 16, 2023
6c2621d
chore: Update from ubi8-minimal:8.8-1072 to ubi8-minimal:8.9-1029
nickboldt Nov 16, 2023
dee46b8
chore: Update from rhel8/go-toolset:1.19.13-2 to rhel8/go-toolset:1.2…
nickboldt Nov 16, 2023
ee12a4c
Merge branch '7.77.x' into pr-update-base-images-1700177458
nickboldt Nov 16, 2023
5704e19
chore: Update from ubi8-minimal:8.8-1072 to ubi8-minimal:8.9-1029
nickboldt Nov 16, 2023
66d4a47
Ran update-go-deps
SDawley Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/dockerfiles/brew.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#

# https://registry.access.redhat.com/rhel8/go-toolset
FROM rhel8/go-toolset:1.19.13-2 as builder
FROM rhel8/go-toolset:1.20.10-3 as builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should be restricted to 1.19 bugfixes

Copy link
Contributor

@nickboldt nickboldt Nov 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but some CVEs are only fixed in 1.20 and 1.21... so this might be a good thing.

see https://issues.redhat.com/browse/CRW-4374?jql=project%20%3D%20CRW%20AND%20component%20%3D%20%22productization%3A%20security%20%26%20legal%22%20and%20resolution%20is%20null%20and%20text~golang

ENV GOPATH=/go/ \
CGO_ENABLED=1
USER root
Expand All @@ -27,7 +27,7 @@ RUN adduser unprivilegeduser && \
cp -rf /che-machine-exec/che-machine-exec /rootfs/go/bin

# https://registry.access.redhat.com/ubi8-minimal
FROM registry.access.redhat.com/ubi8-minimal:8.8-1072 as runtime
FROM registry.access.redhat.com/ubi8-minimal:8.9-1029 as runtime
COPY --from=builder /rootfs /
RUN microdnf install -y openssl; microdnf clean -y all
USER unprivilegeduser
Expand Down
4 changes: 2 additions & 2 deletions build/dockerfiles/rhel.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#

# https://registry.access.redhat.com/ubi8/go-toolset
FROM registry.access.redhat.com/ubi8/go-toolset:1.19.13-2 as builder
FROM registry.access.redhat.com/ubi8/go-toolset:1.20.10-3 as builder
ENV GOPATH=/go/ \
CGO_ENABLED=1
USER root
Expand All @@ -27,7 +27,7 @@ RUN adduser unprivilegeduser && \
cp -rf /che-machine-exec/che-machine-exec /rootfs/go/bin

# https://registry.access.redhat.com/ubi8-minimal
FROM registry.access.redhat.com/ubi8-minimal:8.8-1072 as runtime
FROM registry.access.redhat.com/ubi8-minimal:8.9-1029 as runtime
COPY --from=builder /rootfs /
RUN microdnf install -y openssl && \
microdnf -y update && \
Expand Down