-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update from ubi8/go-toolset:1.19.13-2 to ubi8/go-toolset:1.20.10-3 #273
Conversation
…10-3 Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
…0.10-3 Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.77.x #273 +/- ##
=========================================
Coverage ? 44.31%
=========================================
Files ? 13
Lines ? 519
Branches ? 0
=========================================
Hits ? 230
Misses ? 286
Partials ? 3 ☔ View full report in Codecov by Sentry. |
@@ -10,7 +10,7 @@ | |||
# | |||
|
|||
# https://registry.access.redhat.com/rhel8/go-toolset | |||
FROM rhel8/go-toolset:1.19.13-2 as builder | |||
FROM rhel8/go-toolset:1.20.10-3 as builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this should be restricted to 1.19 bugfixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah but some CVEs are only fixed in 1.20 and 1.21... so this might be a good thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve, tentatively. Not sure if moving to 1.20 breaks anything... or requires updated go.mod/go.sum files, etc.
I am against switching builder to 1.20 without switching the whole project to 1.20 |
OK I've updated the go deps, go mod etc. |
If updating go can be tested, updating to 1.20 is preferable but it can be left out. Updating UBI8 to the 8.9 version is much more important. |
Signed-off-by: Nick Boldt [email protected]