Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update from ubi8/go-toolset:1.19.13-2 to ubi8/go-toolset:1.20.10-3 #273

Closed
wants to merge 6 commits into from

Conversation

che-bot
Copy link
Contributor

@che-bot che-bot commented Nov 16, 2023

Signed-off-by: Nick Boldt [email protected]

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (7.77.x@5c34a13). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             7.77.x     #273   +/-   ##
=========================================
  Coverage          ?   44.31%           
=========================================
  Files             ?       13           
  Lines             ?      519           
  Branches          ?        0           
=========================================
  Hits              ?      230           
  Misses            ?      286           
  Partials          ?        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -10,7 +10,7 @@
#

# https://registry.access.redhat.com/rhel8/go-toolset
FROM rhel8/go-toolset:1.19.13-2 as builder
FROM rhel8/go-toolset:1.20.10-3 as builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should be restricted to 1.19 bugfixes

Copy link
Contributor

@nickboldt nickboldt Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve, tentatively. Not sure if moving to 1.20 breaks anything... or requires updated go.mod/go.sum files, etc.

@tolusha
Copy link
Contributor

tolusha commented Nov 17, 2023

I am against switching builder to 1.20 without switching the whole project to 1.20

@SDawley
Copy link
Contributor

SDawley commented Nov 17, 2023

OK I've updated the go deps, go mod etc.
I tested building the rhel.Dockerfile and Dockerfiles and they build, but as to functional testing that would have to be someone else's domain.

@SDawley
Copy link
Contributor

SDawley commented Nov 17, 2023

If updating go can be tested, updating to 1.20 is preferable but it can be left out.

Updating UBI8 to the 8.9 version is much more important.

@nickboldt nickboldt closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants