Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CRW-3531 update to golang-1.18/ node 16 (because 1.15 and 10.16 are old news) #230

Merged
merged 2 commits into from
Nov 22, 2022
+5 −4
Merged

chore: CRW-3531 update to golang-1.18/ node 16 (because 1.15 and 10.16 are old news) #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46b5874
chore: CRW-3531 update to golang-1.18/ node 18 (because 1.15 and 10.1…
nickboldt Nov 21, 2022
acf1316
could not compile with node:18-alpine, so for now stick with node:16-…
nickboldt Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions build/dockerfiles/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# Copyright (c) 2012-2021 Red Hat, Inc.
# Copyright (c) 2012-2022 Red Hat, Inc.
# This program and the accompanying materials are made
# available under the terms of the Eclipse Public License 2.0
# which is available at https://www.eclipse.org/legal/epl-2.0/
Expand All @@ -12,7 +12,7 @@
# Dockerfile defines che-machine-exec production image eclipse/che-machine-exec-dev
#

FROM golang:1.15.0-alpine as go_builder
FROM docker.io/golang:1.18-alpine as go_builder

ENV USER=machine-exec
ENV UID=12345
Expand All @@ -38,7 +38,8 @@ WORKDIR /che-machine-exec/
COPY . .
RUN CGO_ENABLED=0 GOOS=linux go build -mod=vendor -a -ldflags '-w -s' -a -installsuffix cgo -o /go/bin/che-machine-exec .

FROM docker.io/node:10.16-alpine as cloud_shell_builder
# NOTE: could not compile with node:18-alpine, so for now stick with node:16-alpine
FROM docker.io/node:16-alpine as cloud_shell_builder
COPY --from=go_builder /che-machine-exec/cloud-shell cloud-shell-src
WORKDIR cloud-shell-src
RUN yarn && \
Expand Down
2 changes: 1 addition & 1 deletion build/dockerfiles/rhel.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2019-2021 Red Hat, Inc.
# Copyright (c) 2019-2022 Red Hat, Inc.
# This program and the accompanying materials are made
# available under the terms of the Eclipse Public License 2.0
# which is available at https://www.eclipse.org/legal/epl-2.0/
Expand Down