Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CRW-3531 update to golang-1.18/ node 16 (because 1.15 and 10.16 are old news) #230

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

nickboldt
Copy link
Contributor

@nickboldt nickboldt commented Nov 21, 2022

What does this PR do?

  • chore: CRW-3531 update to golang-1.18/ node 16 (because 1.15 and 10.16 are old news)
  • could not compile with node:18-alpine, so for now stick with node:16-alpine

Change-Id: Ie33cf70926af95246d448f833316bdd1b169d642
Signed-off-by: Nick Boldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-3531

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…6 are old news)

Change-Id: I671170eaac5bb15d76d0543f295f186b1caaac32
Signed-off-by: Nick Boldt <[email protected]>
…alpine

Change-Id: Ie33cf70926af95246d448f833316bdd1b169d642
Signed-off-by: Nick Boldt <[email protected]>
@nickboldt nickboldt changed the title could not compile with node:18-alpine, so... chore: CRW-3531 update to golang-1.18/ node 16 (because 1.15 and 10.16 are old news) Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #230 (acf1316) into main (0efe268) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   44.31%   44.31%           
=======================================
  Files          13       13           
  Lines         519      519           
=======================================
  Hits          230      230           
  Misses        286      286           
  Partials        3        3           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nickboldt nickboldt merged commit 675b2e5 into main Nov 22, 2022
@nickboldt nickboldt deleted the CRW-3531 branch November 22, 2022 14:34
@devstudio-release
Copy link

Build 3.4 :: machineexec_3.x/54: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.4 :: push-latest-container-to-quay_3.x/1109: SUCCESS

Copied: machineexec-rhel8; /job/DS_CI/job/update-digests_3.x triggered;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.12 v4.11 v4.10

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.4 :: sync-to-downstream_3.x/1384: SUCCESS

Build container: devspaces-machineexec synced; /DS_CI/get-sources-rhpkg-container-build_3.x/1396 triggered;

@devstudio-release
Copy link

Build 3.4 :: machineexec_3.x/54: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/1384 triggered

@che-bot che-bot added this to the 7.57 milestone Nov 22, 2022
@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.4 :: copyIIBsToQuay/175: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.4 :: push-latest-container-to-quay_3.x/1110: SUCCESS

Copied: devspaces-operator-bundle; bundle-generated updated;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.12 v4.11 v4.10

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.4 :: sync-to-downstream_3.x/1385: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/1397 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.4 :: operator-bundle_3.x/550: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/1385 triggered

@devstudio-release
Copy link

Build 3.4 :: dsc_3.x/394: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.4 :: dsc_3.x/394: SUCCESS

3.4.0 CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants