Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: How to deploy Eclipse Che on mininkube with Keycloak as OIDC pr… #2408
feat: How to deploy Eclipse Che on mininkube with Keycloak as OIDC pr… #2408
Changes from 3 commits
72f4b4d
67b54d9
dfb3818
b921bfd
e8959f2
0dbb9b2
75dcdfa
311e2b9
30db51b
6c8b093
248979b
526b604
1430651
c9d1f14
756e901
8e42c3b
ddaf18b
4f115ad
6ae36fe
32435b7
d37f1de
40c24b0
0c37bbe
8154ae7
5ab0316
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this article is specific to minikube + keycloak, does it make sense to avoid the template fields? With the wrong values, this could turn into an article that refers to minikube with OpenShift version X or higher, using
oc
instead ofkubectl
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a similar doc about deploy Eclipse Che on minikube [1] with templates instead of hardcoded values.
So, I think we don't have to care much.
/cc @max-cx
[1] https://github.com/eclipse-che/che-docs/blob/70783006917dab18651d0e9a274b98b0a176c47b/modules/administration-guide/pages/installing-che-on-minikube.adoc#L39-L38