Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: How to deploy Eclipse Che on mininkube with Keycloak as OIDC pr… #2408

Merged
merged 25 commits into from
Aug 31, 2022

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jul 22, 2022

…ovider

Signed-off-by: Anatolii Bazko [email protected]

What does this pull request change?

How to deploy Eclipse Che on mininkube with Keycloak as OIDC provider

What issues does this pull request fix or reference?

eclipse-che/che#21304

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Jul 22, 2022

🎊 Navigate the preview: https://630f04fc4b042e57ea6f34bd--eclipse-che-docs-pr.netlify.app 🎊

Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha tolusha marked this pull request as ready for review July 22, 2022 13:52
@tolusha tolusha requested review from rkratky, themr0c and a team as code owners July 22, 2022 13:52
@tolusha tolusha requested review from amisevsk and l0rd July 22, 2022 13:52
Signed-off-by: Anatolii Bazko <[email protected]>
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments on the text; I haven't tested the procedure directly yet.

= Installing {prod-short} on Minikube with {identity-provider} as OIDC Identity Provider

This article explains how to create a single-node {kubernetes} cluster with Minikube to deploy {prod-short} and
configure it to use {identity-provider} as OIDC identity provider.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this article is specific to minikube + keycloak, does it make sense to avoid the template fields? With the wrong values, this could turn into an article that refers to minikube with OpenShift version X or higher, using oc instead of kubectl.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a similar doc about deploy Eclipse Che on minikube [1] with templates instead of hardcoded values.
So, I think we don't have to care much.
/cc @max-cx

[1] https://github.com/eclipse-che/che-docs/blob/70783006917dab18651d0e9a274b98b0a176c47b/modules/administration-guide/pages/installing-che-on-minikube.adoc#L39-L38

Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
@max-cx max-cx self-assigned this Jul 29, 2022
Signed-off-by: Anatolii Bazko <[email protected]>
@max-cx
Copy link
Contributor

max-cx commented Aug 9, 2022

Apologies for the delay with reviewing this PR.

@tolusha tolusha mentioned this pull request Aug 25, 2022
82 tasks
tolusha and others added 17 commits August 31, 2022 09:44
@tolusha tolusha merged commit 0747c76 into main Aug 31, 2022
@tolusha tolusha deleted the 21304 branch August 31, 2022 14:25
@che-bot che-bot added this to the 7.54 milestone Aug 31, 2022
max-cx added a commit to max-cx/che-docs that referenced this pull request Sep 1, 2022
eclipse-che#2408)

* feat: How to deploy Eclipse Che on minikube with Keycloak as OIDC provider

Signed-off-by: Anatolii Bazko <[email protected]>
Co-authored-by: Angel Misevski <[email protected]>
Co-authored-by: Max Leonov <[email protected]>
max-cx added a commit to max-cx/che-docs that referenced this pull request Sep 2, 2022
eclipse-che#2408)

* feat: How to deploy Eclipse Che on minikube with Keycloak as OIDC provider

Signed-off-by: Anatolii Bazko <[email protected]>
Co-authored-by: Angel Misevski <[email protected]>
Co-authored-by: Max Leonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants