-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: How to deploy Eclipse Che on mininkube with Keycloak as OIDC pr… #2408
Conversation
…ovider Signed-off-by: Anatolii Bazko <[email protected]>
🎊 Navigate the preview: https://630f04fc4b042e57ea6f34bd--eclipse-che-docs-pr.netlify.app 🎊 |
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments on the text; I haven't tested the procedure directly yet.
= Installing {prod-short} on Minikube with {identity-provider} as OIDC Identity Provider | ||
|
||
This article explains how to create a single-node {kubernetes} cluster with Minikube to deploy {prod-short} and | ||
configure it to use {identity-provider} as OIDC identity provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this article is specific to minikube + keycloak, does it make sense to avoid the template fields? With the wrong values, this could turn into an article that refers to minikube with OpenShift version X or higher, using oc
instead of kubectl
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a similar doc about deploy Eclipse Che on minikube [1] with templates instead of hardcoded values.
So, I think we don't have to care much.
/cc @max-cx
modules/administration-guide/pages/installing-che-on-minikube-keycloak-oidc.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-che-on-minikube-keycloak-oidc.adoc
Show resolved
Hide resolved
modules/administration-guide/pages/installing-che-on-minikube-keycloak-oidc.adoc
Outdated
Show resolved
Hide resolved
…keycloak-oidc.adoc Co-authored-by: Angel Misevski <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Apologies for the delay with reviewing this PR. |
modules/administration-guide/pages/installing-che-on-minikube-keycloak-oidc.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-che-on-minikube-keycloak-oidc.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-che-on-minikube-keycloak-oidc.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-che-on-minikube-keycloak-oidc.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-che-on-minikube-keycloak-oidc.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-che-on-minikube-keycloak-oidc.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-che-on-minikube-keycloak-oidc.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-che-on-minikube-keycloak-oidc.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-che-on-minikube-keycloak-oidc.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-che-on-minikube-keycloak-oidc.adoc
Outdated
Show resolved
Hide resolved
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
…keycloak-oidc.adoc Co-authored-by: Max Leonov <[email protected]>
eclipse-che#2408) * feat: How to deploy Eclipse Che on minikube with Keycloak as OIDC provider Signed-off-by: Anatolii Bazko <[email protected]> Co-authored-by: Angel Misevski <[email protected]> Co-authored-by: Max Leonov <[email protected]>
eclipse-che#2408) * feat: How to deploy Eclipse Che on minikube with Keycloak as OIDC provider Signed-off-by: Anatolii Bazko <[email protected]> Co-authored-by: Angel Misevski <[email protected]> Co-authored-by: Max Leonov <[email protected]>
…ovider
Signed-off-by: Anatolii Bazko [email protected]
What does this pull request change?
How to deploy Eclipse Che on mininkube with Keycloak as OIDC provider
What issues does this pull request fix or reference?
eclipse-che/che#21304
Specify the version of the product this pull request applies to
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.