-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
procedures: Add new requirement for some objects to have part-of label #2170
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
06f12c0
Add new requirement for some objects to have part-of label
mmorhun c3483e7
Apply review remarks
mmorhun 10f8e01
Merge branch 'master' into che-20647
nickboldt 8285fdd
Update modules/installation-guide/partials/proc_importing-untrusted-t…
tolusha 9ed947f
Update modules/installation-guide/partials/proc_importing-untrusted-t…
tolusha 701aca6
Merge branch 'master' into che-20647
tolusha 3dff14b
Merge branch 'master' of github.com:mmorhun/che-docs into che-20647
mmorhun 04d2aaa
Standardize replaceble names style
mmorhun b7e168c
Apply suggestions from code review
mmorhun 9d274dd
Apply suggestions from code review
mmorhun a4eba2c
Apply suggestions from code review
mmorhun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@max-cx, we should not use 'shell' highlighting on command-line stuff. When you type on the command line, there's no highlighting either. The syntax-highlight feature should only be used when you're listing code. So, for 'shell', it would be for listing the content of shell scripts.
Not sure what you mean by
because \ after $ doesn't render
...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened a separate issue for this: https://issues.redhat.com/browse/RHDEVDOCS-3498
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, this is outside of the scope of this PR because this syntax is in the rest of this file and possibly in other files as well (so I've opened a new issue for this).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an explanatory comment to the JIRA issue. TL;DR: the not-rendered backslash is intentional.