Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

procedures: Add new requirement for some objects to have part-of label #2170

Merged
merged 11 commits into from
Nov 26, 2021
Merged

procedures: Add new requirement for some objects to have part-of label #2170

merged 11 commits into from
Nov 26, 2021

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Nov 23, 2021

Signed-off-by: Mykola Morhun [email protected]

What does this pull request change?

Adds a new requirement to have app.kubernetes.io/part-of=che.eclipse.org label on the following objects:

  • spec.server.cheHostTLSSecret
  • spec.server.cheClusterRoles
  • spec.server.cheWorkspaceClusterRole
  • spec.server.serverTrustStoreConfigMapName
  • spec.server.gitSelfSignedCert ('che-git-self-signed-cert' config map)
  • spec.server.proxySecret
  • spec.database.chePostgresSecret
  • spec.auth.identityProviderSecret
  • spec.auth.identityProviderPostgresSecret
  • spec.k8s.tlsSecretName

What issues does this pull request fix or reference?

eclipse-che/che#20647

Specify the version of the product this pull request applies to

next

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@mmorhun mmorhun requested a review from a team as a code owner November 23, 2021 09:00
@mmorhun mmorhun self-assigned this Nov 23, 2021
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@tolusha tolusha mentioned this pull request Nov 23, 2021
Closed
27 tasks
max-cx
max-cx reviewed Nov 23, 2021
View reviewed changes
modules/installation-guide/partials/proc_importing-untrusted-tls-certificates-old.adoc Outdated
@@ -51,6 +51,13 @@ $ {orch-cli} create configmap ca-certs --from-file=__<certificate-file-path>__ -
+
To apply more than one certificate, add another `--from-file=_<certificate-file-path>_` option to the above command.

This comment was marked as resolved.

Sign in to view

@mmorhun
Apply review remarks
c3483e7 
Signed-off-by: Mykola Morhun <[email protected]>
@nickboldt nickboldt self-requested a review November 23, 2021 14:56
nickboldt
nickboldt approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding my +1 just so this PR is not blocked from being merged. Up to the repo owner / PR owner / @tolusha if it's safe to merge.

@themr0c
Copy link
Contributor

themr0c commented Nov 23, 2021

As the file proc_importing-untrusted-tls-certificates-old.adoc is documenting only Che version lower than v7.23.0, the changes on this file are not relevant. We need to remove this file cleanly in a later task, see https://issues.redhat.com/browse/RHDEVDOCS-3497.

@themr0c themr0c changed the title docs: Add new requirement for some objects to have part-of label procedures: Add new requirement for some objects to have part-of label Nov 24, 2021
max-cx
max-cx reviewed Nov 25, 2021
View reviewed changes
modules/installation-guide/partials/proc_configuring-che-hostname.adoc
@@ -29,15 +29,23 @@ $ {orch-cli} create {orch-namespace} {prod-namespace}
+
[subs="+quotes,attributes"]

This comment was marked as off-topic.

Sign in to view

max-cx
max-cx reviewed Nov 25, 2021
View reviewed changes
modules/installation-guide/partials/proc_configuring-che-hostname.adoc
@@ -29,15 +29,23 @@ $ {orch-cli} create {orch-namespace} {prod-namespace}
+
[subs="+quotes,attributes"]

This comment was marked as resolved.

Sign in to view

modules/installation-guide/partials/proc_configuring-che-hostname.adoc
@@ -29,15 +29,23 @@ $ {orch-cli} create {orch-namespace} {prod-namespace}
+
[subs="+quotes,attributes"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a separate issue for this: https://issues.redhat.com/browse/RHDEVDOCS-3498

modules/installation-guide/partials/proc_configuring-che-hostname.adoc
@@ -29,15 +29,23 @@ $ {orch-cli} create {orch-namespace} {prod-namespace}
+
[subs="+quotes,attributes"]

This comment was marked as off-topic.

Sign in to view

modules/installation-guide/partials/proc_configuring-che-hostname.adoc
@@ -29,15 +29,23 @@ $ {orch-cli} create {orch-namespace} {prod-namespace}
+
[subs="+quotes,attributes"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, this is outside of the scope of this PR because this syntax is in the rest of this file and possibly in other files as well (so I've opened a new issue for this).

modules/installation-guide/partials/proc_configuring-che-hostname.adoc Outdated Show resolved Hide resolved
max-cx
max-cx requested changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@max-cx max-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few final nitpicks with suggested changes.
I opened issue RHDEVDOCS-3498 to address other required changes that are outside of the scope of this PR and of the diffs and that have global scope for the docs.
User-replaced values in the diffs follow the syntax in the remainder of the file deliberately for consistency with the original procedure steps within the file.

@max-cx
Copy link
Contributor

max-cx commented Nov 26, 2021

Just a few final nitpicks with suggested changes. I opened issue RHDEVDOCS-3498 to address other required changes that are outside of the scope of this PR and of the diffs and that have global scope for the docs. User-replaced values in the diffs follow the syntax in the remainder of the file deliberately for consistency with the original procedure steps within the file.

Language and modular docs review of the diffs is completed.

@themr0c themr0c merged commit 5abc60a into eclipse-che:master Nov 26, 2021
@che-bot che-bot added this to the 7.40 milestone Nov 26, 2021
@mmorhun mmorhun deleted the che-20647 branch November 26, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-cx max-cx max-cx approved these changes

@tolusha tolusha tolusha approved these changes

@themr0c themr0c themr0c approved these changes

@rkratky rkratky Awaiting requested review from rkratky

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees

@mmorhun mmorhun

@max-cx max-cx

Labels
None yet
Projects
None yet
Milestone
7.40
Development

Successfully merging this pull request may close these issues.
7 participants
@mmorhun @max-cx @themr0c @nickboldt @tolusha @rkratky @che-bot