Handle gracefully when an invalid devfile is found in a git repository

[olexii4]

Signed-off-by: Oleksii Orel [email protected]

What does this PR do?

Add a warning message for the user and prompt him if the workspace should start anyway (ignoring the existing devfile).

What issues does this PR fix or reference?

fixes eclipse-che/che#20738

Is it tested? How?

1. Deploy Che (dashboard image: quay.io/eclipse/che-dashboard:pr-643).
2. Try to accept the factory with the wrong URL, like
   $CHE_HOST#https://github.com/AObuchow/che-dashboardrrrr.
   An error message should be shown:
   
3. Try to accept the factory from the repo with an invalid devfile scheme, like
   $CHE_HOST#https://github.com/olexii4/che-dashboard.
   A warning message about starting anyway should be shown:
   
4. Try to accept the factory from the repo with a valid devfile wich includes unsuported attributes for target platform, like
   $CHE_HOST#https://github.com/AObuchow/che-dashboard.
   A warning message about starting anyway should be shown:
   

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[codecov]

Codecov Report

Merging #643 (5c74b7c) into main (dcee2f7) will decrease coverage by 0.24%.
The diff coverage is 40.50%.

@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
- Coverage   58.53%   58.28%   -0.25%     
==========================================
  Files         247      247              
  Lines        8318     8381      +63     
  Branches     1364     1379      +15     
==========================================
+ Hits         4869     4885      +16     
- Misses       3256     3299      +43     
- Partials      193      197       +4     

Flag	Coverage Δ
unittests	58.28% <40.50%> (-0.25%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...dashboard-frontend/src/services/bootstrap/index.ts	0.00% <0.00%> (ø)
...hboard-frontend/src/store/FactoryResolver/index.ts	73.25% <ø> (ø)
...iners/Loader/Factory/Steps/Fetch/Devfile/index.tsx	80.95% <39.13%> (-7.42%)	⬇️
...iners/Loader/Factory/Steps/Apply/Devfile/index.tsx	79.13% <39.28%> (-13.35%)	⬇️
...er/Factory/Steps/CheckExistingWorkspaces/index.tsx	85.39% <42.85%> (-1.97%)	⬇️
...-frontend/src/store/DevfileRegistries/selectors.ts	80.43% <61.53%> (-7.45%)	⬇️
...es/GetStarted/GetStartedTab/SamplesListGallery.tsx	61.95% <100.00%> (-0.41%)	⬇️
...end/src/pages/WorkspaceDetails/EditorTab/index.tsx	59.37% <0.00%> (-0.95%)	⬇️
...d-frontend/src/services/workspace-adapter/index.ts	69.93% <0.00%> (-0.62%)	⬇️
...d/src/pages/WorkspaceDetails/OverviewTab/index.tsx	59.57% <0.00%> (-0.43%)	⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-643

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-643

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-643

[che-bot]

Click here to review and test in web IDE:

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-643

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-643

[che-bot]

Click here to review and test in web IDE:

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-643

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[che-bot]

Click here to review and test in web IDE:

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-643

[che-bot]

Click here to review and test in web IDE:

[openshift-ci]

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v10-dashboard-happy-path	1bb4ed1	link	true	/test v10-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-643

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment